From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXCie-0004R2-Jk for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:48:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXCiV-00049K-IS for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:48:24 -0400 Message-ID: <5342D6C9.7090308@gmail.com> Date: Mon, 07 Apr 2014 11:48:09 -0500 From: Tom Musta MIME-Version: 1.0 References: <1396882231-6660-1-git-send-email-tommusta@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-ppc@nongnu.org" , QEMU Developers On 4/7/2014 10:00 AM, Peter Maydell wrote: > It seems a touch dubious to assume the area of memory > being dissassembled is necessarily the same endianness > the CPU happens to be currently... I don't disagree but it is less dubious than relying on TARGET_WORDS_BIGENDIAN, which is what the code currently does. I think the only other alternative is to put it back on the user via options on the command, e.g. xp/8il xp/8ib But, I would contend that the using the MSR[LE] bit would still be a better default than TARGET_WORDS_BIGENDIAN if an option is not specified. Thanks for the other comments ... I will incorporate.