From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WXDLK-0008E4-VP
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 13:28:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WXDLF-0008MZ-7y
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 13:28:22 -0400
Message-ID: <5342E02C.3040702@gmail.com>
Date: Mon, 07 Apr 2014 12:28:12 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1396817736-26801-1-git-send-email-agraf@suse.de>
In-Reply-To: <1396817736-26801-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Only enter MSR_POW when no
 interrupts pending
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 4/6/2014 3:55 PM, Alexander Graf wrote:
> We were entering the power saving state even when interrupts (like an
> external interrupt or a decrementer interrupt) were still in flight.
> 
> In case we find a pending interrupt, don't enter power saving state.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  target-ppc/helper_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-ppc/helper_regs.h b/target-ppc/helper_regs.h
> index f7ec9c2..271fddf 100644
> --- a/target-ppc/helper_regs.h
> +++ b/target-ppc/helper_regs.h
> @@ -101,7 +101,7 @@ static inline int hreg_store_msr(CPUPPCState *env, target_ulong value,
>      hreg_compute_hflags(env);
>  #if !defined(CONFIG_USER_ONLY)
>      if (unlikely(msr_pow == 1)) {
> -        if ((*env->check_pow)(env)) {
> +        if (!env->pending_interrupts && (*env->check_pow)(env)) {
>              cs->halted = 1;
>              excp = EXCP_HALTED;
>          }
> 

Reviewed-by: Tom Musta <tmusta@gmail.com>