From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXGpe-0002pU-CK for qemu-devel@nongnu.org; Mon, 07 Apr 2014 17:11:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXGpZ-0003hD-3K for qemu-devel@nongnu.org; Mon, 07 Apr 2014 17:11:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXGpY-0003gu-Qu for qemu-devel@nongnu.org; Mon, 07 Apr 2014 17:11:49 -0400 Message-ID: <53431491.7010407@redhat.com> Date: Mon, 07 Apr 2014 15:11:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394436370-8908-1-git-send-email-famz@redhat.com> <1394436370-8908-13-git-send-email-famz@redhat.com> In-Reply-To: <1394436370-8908-13-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sxW7FjavQCFQPaEOXtgJ6RMuP0TXOURcA" Subject: Re: [Qemu-devel] [PATCH v17 12/14] block: Add blockdev-backup to transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, rjones@redhat.com, jcody@redhat.com, armbru@redhat.com, ptoscano@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sxW7FjavQCFQPaEOXtgJ6RMuP0TXOURcA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 01:26 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++= > qapi-schema.json | 1 + > 2 files changed, 49 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -1972,6 +1972,7 @@ > 'data': { > 'blockdev-snapshot-sync': 'BlockdevSnapshot', > 'drive-backup': 'DriveBackup', > + 'blockdev-backup': 'BlockdevBackup', > 'abort': 'Abort', > 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal' > } } It might be nice to mention that the union was expanded in 2.1; something like: # A discriminated record of operations that can be performed with # @transaction. # # Since 1.1, blockdev-backup since 2.1 ## { 'union': 'TransactionAction', Of course, this is a pre-existing problem, as we've added other actions since 1.1 (blockdev-snapshot-internal-sync in 1.7, for example), so it could be justified as a separate patch. But it can't hurt to start being more thorough in our docs. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sxW7FjavQCFQPaEOXtgJ6RMuP0TXOURcA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTQxSRAAoJEKeha0olJ0NqoEQH/1VZLVcgJedQbujfXlF5H+m9 d1eUFkNM0ks8U4DHcUVjEJWVcwleE1qjj5f4i8uxNoisszdq8eJsX9Ntrfh+RbNj 6aj8fiPH0zOLdmYNoxBiOHJDsnayORRObgjiFWuTHf1ESXBZekDIPQH+wIJeN8/h KmyJYkSSvzejCkUkx+UOHu2Hv1FkUzhVCdmViG1kMUqgGhcyqVGlj6v0MnL84nx2 f+IDvYLkfiNSt4awLGd0jxEE6mdaDQirzpnwtJV9ZmF6dC6ZPpUHBKcZn+KvtUdV S7T0yr+c65jHFOVCP8adCwB2DRdmn1Q2IauywX4s1gfcsXX8ggH44vEPJVzrKig= =K2tq -----END PGP SIGNATURE----- --sxW7FjavQCFQPaEOXtgJ6RMuP0TXOURcA--