* [Qemu-devel] [PATCH] Fix grammar in comment
@ 2014-04-07 17:42 Stefan Weil
2014-04-08 5:39 ` Peter Crosthwaite
2014-04-08 6:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2014-04-07 17:42 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/i2c/smbus_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 86f35c1..72c09cb 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -71,7 +71,7 @@ static void eeprom_write_data(SMBusDevice *dev, uint8_t cmd, uint8_t *buf, int l
printf("eeprom_write_byte: addr=0x%02x cmd=0x%02x val=0x%02x\n",
dev->i2c.address, cmd, buf[0]);
#endif
- /* An page write operation is not a valid SMBus command.
+ /* A page write operation is not a valid SMBus command.
It is a block write without a length byte. Fortunately we
get the full block anyway. */
/* TODO: Should this set the current location? */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Fix grammar in comment
2014-04-07 17:42 [Qemu-devel] [PATCH] Fix grammar in comment Stefan Weil
@ 2014-04-08 5:39 ` Peter Crosthwaite
2014-04-08 6:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Peter Crosthwaite @ 2014-04-08 5:39 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel@nongnu.org Developers
On Tue, Apr 8, 2014 at 3:42 AM, Stefan Weil <sw@weilnetz.de> wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> hw/i2c/smbus_eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index 86f35c1..72c09cb 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -71,7 +71,7 @@ static void eeprom_write_data(SMBusDevice *dev, uint8_t cmd, uint8_t *buf, int l
> printf("eeprom_write_byte: addr=0x%02x cmd=0x%02x val=0x%02x\n",
> dev->i2c.address, cmd, buf[0]);
> #endif
> - /* An page write operation is not a valid SMBus command.
> + /* A page write operation is not a valid SMBus command.
> It is a block write without a length byte. Fortunately we
> get the full block anyway. */
> /* TODO: Should this set the current location? */
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix grammar in comment
2014-04-07 17:42 [Qemu-devel] [PATCH] Fix grammar in comment Stefan Weil
2014-04-08 5:39 ` Peter Crosthwaite
@ 2014-04-08 6:56 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-04-08 6:56 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-08 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-07 17:42 [Qemu-devel] [PATCH] Fix grammar in comment Stefan Weil
2014-04-08 5:39 ` Peter Crosthwaite
2014-04-08 6:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).