From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44815)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WXS7W-0007Rp-MJ
	for qemu-devel@nongnu.org; Tue, 08 Apr 2014 05:15:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WXS7R-0006ad-AR
	for qemu-devel@nongnu.org; Tue, 08 Apr 2014 05:15:06 -0400
Message-ID: <5343BE12.5090000@suse.de>
Date: Tue, 08 Apr 2014 11:14:58 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1395493406-29154-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1395493406-29154-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6] spapr_hcall: add
 address-translation-mode-on-interrupt resource in H_SET_MODE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Mike Day <ncmike@ncultra.org>, Jeffrey Scheel <scheel@us.ibm.com>, qemu-ppc@nongnu.org


On 22.03.14 14:03, Alexey Kardashevskiy wrote:
> This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from
> the H_SET_MODE, for POWER8 (PowerISA 2.07) only.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Mike Day <ncmike@ncultra.org>

Unfortunately I'm lacking a specification to verify this patch against, 
so I can not apply it upstream.


Alex

> ---
> Changes:
> v6:
> * replaced "return" with "goto out"/"break" for better consistency
> ---
>   hw/ppc/spapr_hcall.c | 29 +++++++++++++++++++++++++++++
>   target-ppc/cpu.h     |  2 ++
>   2 files changed, 31 insertions(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 0bae053..7e4d7ff 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -746,6 +746,35 @@ static target_ulong h_set_mode(PowerPCCPU *cpu, sPAPREnvironment *spapr,
>           default:
>               ret = H_UNSUPPORTED_FLAG;
>           }
> +    } else if (resource == H_SET_MODE_RESOURCE_ADDR_TRANS_MODE) {
> +        PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);
> +
> +        if (!(pcc->insns_flags2 & PPC2_ISA207S)) {
> +            ret = H_P2;
> +            goto out;
> +        }
> +        if (value1) {
> +            ret = H_P3;
> +            goto out;
> +        }
> +        if (value2) {
> +            ret = H_P4;
> +            goto out;
> +        }
> +        switch (mflags) {
> +        case 0:
> +        case 2:
> +        case 3:
> +            CPU_FOREACH(cs) {
> +                set_spr(cs, SPR_LPCR, mflags << LPCR_AIL_SH, LPCR_AIL);
> +            }
> +            ret = H_SUCCESS;
> +            break;
> +
> +        default:
> +            ret = H_UNSUPPORTED_FLAG;
> +            break;
> +        }
>       }
>   
>   out:
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 2719c08..39527e2 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -463,6 +463,8 @@ struct ppc_slb_t {
>   #define MSR_LE   0  /* Little-endian mode                           1 hflags */
>   
>   #define LPCR_ILE (1 << (63-38))
> +#define LPCR_AIL      0x01800000      /* Alternate interrupt location */
> +#define LPCR_AIL_SH   (63-40)
>   
>   #define msr_sf   ((env->msr >> MSR_SF)   & 1)
>   #define msr_isf  ((env->msr >> MSR_ISF)  & 1)