From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
Date: Tue, 08 Apr 2014 20:00:20 +0800 [thread overview]
Message-ID: <5343E4D4.6070305@gmail.com> (raw)
In-Reply-To: <53414941.5040908@gmail.com>
In "vl.c", at least, we can simplify the code below, so can let readers
read professional C code (especially for new readers, which often start
reading code at main function).
- remove useless 'continue' in main().
- remove redundant local variable 'res' in get_boot_device().
- remove local variable 'args' in the middle of code block in main().
The following 3 patches are for the 3 'remove' above.
And "vl.c" has a very long function main() which is about 17K lines.
Next, it can be split into sub-functions (so can bypass another code
style issue: multiple "{...}" styles within "swith(...)").
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
vl.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
next prev parent reply other threads:[~2014-04-08 12:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 1:16 [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() Chen Gang
2014-03-27 7:55 ` Marcel Apfelbaum
2014-03-27 9:54 ` Chen Gang
2014-03-27 8:59 ` Markus Armbruster
2014-03-27 10:01 ` Chen Gang
2014-03-30 14:44 ` Chen Gang
2014-03-31 12:38 ` Markus Armbruster
2014-03-31 12:53 ` Chen Gang
2014-03-31 13:01 ` Peter Maydell
2014-03-31 13:12 ` Chen Gang
2014-03-31 13:16 ` Peter Maydell
2014-03-31 13:26 ` Chen Gang
2014-03-31 13:33 ` Peter Maydell
2014-03-31 23:50 ` Chen Gang
2014-04-04 9:39 ` [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely Chen Gang
2014-04-04 10:57 ` Markus Armbruster
2014-04-06 12:30 ` Chen Gang
2014-04-06 6:32 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-04-06 12:32 ` Chen Gang
2014-04-08 12:00 ` Chen Gang [this message]
2014-04-08 12:01 ` [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue' Chen Gang
2014-04-08 12:02 ` [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' Chen Gang
2014-04-08 12:05 ` [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343E4D4.6070305@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).