From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXYlq-00070d-Ha for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:21:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXYlk-0000B7-C3 for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:21:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXYlk-00009C-4a for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:21:04 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s38GL0Xx002540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Apr 2014 12:21:01 -0400 Message-ID: <534421EB.9050801@redhat.com> Date: Tue, 08 Apr 2014 10:20:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396961442-24046-1-git-send-email-mreitz@redhat.com> <1396961442-24046-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1396961442-24046-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M3H16aGi0h5GWnKUgxSOCi6J7U6O5bngG" Subject: Re: [Qemu-devel] [PATCH v2 1/6] block-commit: Expose granularity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M3H16aGi0h5GWnKUgxSOCi6J7U6O5bngG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/08/2014 06:50 AM, Max Reitz wrote: > Allow QMP users to manipulate the granularity used in the block-commit > command. >=20 > Signed-off-by: Max Reitz > --- > +++ b/include/block/block_int.h > @@ -426,6 +426,7 @@ void stream_start(BlockDriverState *bs, BlockDriver= State *base, > * @top: Top block device to be committed. > * @base: Block device that will be written into, and become the new t= op. > * @speed: The maximum speed, in bytes per second, or 0 for unlimited.= > + * @granularity: The granularity, in bytes, or 0 for a default value. > * @on_error: The action to take upon error. > * @cb: Completion function for the job. > * @opaque: Opaque pointer value passed to @cb. > @@ -433,7 +434,7 @@ void stream_start(BlockDriverState *bs, BlockDriver= State *base, > * > */ > void commit_start(BlockDriverState *bs, BlockDriverState *base, > - BlockDriverState *top, int64_t speed, > + BlockDriverState *top, int64_t speed, int64_t granula= rity, > BlockdevOnError on_error, BlockDriverCompletionFunc *= cb, > void *opaque, Error **errp); Worth fixing the indentation while you are touching this? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M3H16aGi0h5GWnKUgxSOCi6J7U6O5bngG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTRCHrAAoJEKeha0olJ0NqkF4H/i66U5uf8+NNRXWLBWpu1sul kDSoffF/U2cQV8kJteZSRzuzjQ80fDn3lKumwTff3gnDoLEVSWFwPfSSXWKSWS1B 27tmhov2TUCensJGTOVVVafvg6ZqBLDo/heBa4RZMXanmBOYa+y/shG6AhprW3Fo 7kepZM3UYy3h0Uwb60/78trhOLN8Tw6OZWMJSV1/qC3rpvlpr5CWNc02DtELtCRI HZVs0AMZjXVmQXEHkAWGRrHt1qxGt7dPXl/urlwc4L0uFglI6sZUtb5KhJmTCnUv jT5sOX1pMRcbytPspbfJ1IhynJwyvcCpjusS21uI8kpBEfVe1xz95iLizh5oH08= =kzTP -----END PGP SIGNATURE----- --M3H16aGi0h5GWnKUgxSOCi6J7U6O5bngG--