From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXZ48-0007cP-0T for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:40:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXZ42-0007t6-S7 for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:40:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXZ42-0007sx-Iy for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:39:58 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s38Gdu6b011778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Apr 2014 12:39:57 -0400 Message-ID: <53442659.1000300@redhat.com> Date: Tue, 08 Apr 2014 10:39:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396961442-24046-1-git-send-email-mreitz@redhat.com> <1396961442-24046-4-git-send-email-mreitz@redhat.com> <20140408151458.GE6262@noname.str.redhat.com> In-Reply-To: <20140408151458.GE6262@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kl2sjICFEHhdLx8BnSWl3kHhVQET4BFGL" Subject: Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kl2sjICFEHhdLx8BnSWl3kHhVQET4BFGL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/08/2014 09:14 AM, Kevin Wolf wrote: > Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: >> qemu-img should use QMP commands whenever possible in order to ensure >> feature completeness of both online and offline image operations. As >> qemu-img itself has no access to QMP (since this would basically requi= re >> just everything being linked into qemu-img), imitate QMP's >> implementation of block-commit by using commit_active_start() and then= >> waiting for the block job to finish. >=20 > Leaves us with the HMP commit command that uses the old bdrv_commit() > function. I wonder if we can get rid of it by letting the HMP command > stop the VM, do a live commit, and then restart the VM. Not a bad idea, actually. Of course, as additional patches. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kl2sjICFEHhdLx8BnSWl3kHhVQET4BFGL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTRCZZAAoJEKeha0olJ0NqybkH/24x2sphKYlM+6ZpopVyrzvU 1a/Il6i2xqYkueSA+SqiImbBdJAis2Zcwc9WwFkyuSMbvAqoM5/TllVo7DGAuGjf x8uwMKiLFek6cC6w7nZWy+zpcXKw2OuDUsnPn/XwdQ5bWbd/Sw9m8j01W41oNHix 7vJtSjAkRkUYNTf0UF8p/o0rkMi2ESQKAk+wMtOgjyzw8/HP9vN3+UDpc9dmFxI/ Fwpxq+k+1BwScHrf+KTHh096W8pvMzgk5qqL6KPiCsI54PVksX1hUTzVwA5UOfVz db23lbrUm/3HC03e0OrOeeTc3ZBwvsYVfouC6AOeA559AfmJ+/Kzxt7useyHEQ4= =iWip -----END PGP SIGNATURE----- --kl2sjICFEHhdLx8BnSWl3kHhVQET4BFGL--