From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction
Date: Tue, 11 Oct 2022 09:39:36 -0700 [thread overview]
Message-ID: <53453ca7-295d-7fc6-b053-94cedb72cfef@linaro.org> (raw)
In-Reply-To: <ba70d3ff-cf74-2da4-62bc-fcc05fd990f9@redhat.com>
On 10/11/22 06:24, David Hildenbrand wrote:
>>>> +++ b/tests/tcg/s390x/vf.c
>>>
>>> In general, we use "vx" when talking about vector extension. Maybe name this
>>> vx.c
>>
>> Ok... or maybe "vecstring.c" in case we only want to test the vector string
>> functions here? (they are in a separate chapter in the PoP)
>
> Also works for me. Or "vx_str.c" or sth like that.
If we're going to bikeshed the name, use the insn being tested.
What you don't want is one big file testing lots of things.
What you do want is lots of little files each testing one thing.
r~
next prev parent reply other threads:[~2022-10-11 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 10:14 [PATCH] target/s390x: Fix emulation of the VISTR instruction Thomas Huth
2022-10-11 12:30 ` David Hildenbrand
2022-10-11 12:45 ` Thomas Huth
2022-10-11 13:24 ` David Hildenbrand
2022-10-11 16:39 ` Richard Henderson [this message]
2022-10-11 14:14 ` Alex Bennée
2022-10-11 17:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53453ca7-295d-7fc6-b053-94cedb72cfef@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).