From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXsEa-0004iX-4k for qemu-devel@nongnu.org; Wed, 09 Apr 2014 09:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXsEV-0005li-5w for qemu-devel@nongnu.org; Wed, 09 Apr 2014 09:08:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXsEU-0005ld-Us for qemu-devel@nongnu.org; Wed, 09 Apr 2014 09:08:03 -0400 Message-ID: <5345462E.4090301@redhat.com> Date: Wed, 09 Apr 2014 07:07:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1397009012-475-1-git-send-email-zhlcindy@gmail.com> <5344BC91.7050507@redhat.com> <5344DC5C.1020300@gmail.com> In-Reply-To: <5344DC5C.1020300@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mJbDwDTw5rwvei6c3hWmGJjv5QplkFEiu" Subject: Re: [Qemu-devel] [libvirt] [PATCH 1/1] Enable QEMU_CAPS_PCI_MULTIBUS capability for QEMU2.0 forward. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Zhang Cc: libvir-list@redhat.com, aik@au1.ibm.com, "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mJbDwDTw5rwvei6c3hWmGJjv5QplkFEiu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [adding qemu] On 04/08/2014 11:36 PM, Li Zhang wrote: > On 2014=E5=B9=B404=E6=9C=8809=E6=97=A5 11:20, Eric Blake wrote: >> On 04/08/2014 08:03 PM, Li Zhang wrote: >>> From: Li Zhang >>> >>> For QEMU2.0 forward version, it supports PCI multiBUS. >>> Currently, libvirt still disables it which causes an error >>> "Bus 'pci' not found". >>> >>> Signed-off-by: Li Zhang >>> --- >>> src/qemu/qemu_capabilities.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilitie= s.c >>> index 2c8ec10..b49398f 100644 >>> --- a/src/qemu/qemu_capabilities.c >>> +++ b/src/qemu/qemu_capabilities.c >>> @@ -3019,6 +3019,9 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCa= ps, >>> if (qemuCaps->version >=3D 1006000) >>> virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY); >>> + if (qemuCaps->version >=3D 2000000) >>> + virQEMUCapsSet(qemuCaps, QEMU_CAPS_PCI_MULTIBUS); >>> + >> This is a version number check, which is bad. Is there a QMP command = we >> can issue that gives a more reliable answer of whether the feature is >> present? >> > Hi Eric, >=20 > I can't find any QMP command for MULTIBUS in QEMU. > There is only one "query-pci" to list PCI bus and devices information. Maybe it's my fault for not being more vocal when the bus rename was being proposed on the qemu list, but libvirt really does want a way to probe via QMP whether the 'pci.0' (multibus) vs. 'pci' naming should be used for a given machine. Is there an existing command we can use, or is this something that we need to fix early on in qemu 2.1 and backport to 2.0-stable? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mJbDwDTw5rwvei6c3hWmGJjv5QplkFEiu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTRUYuAAoJEKeha0olJ0Nq5HYIAIjZzbmzvUbKl9Vt81upg7py 7wNSsfGJRiVNyG5Syr9yQ6AmDlJnuBYcA59bVugjklnL4MsLRb7EkgQSsDsCbUPK m2qXAhZ8wIGuSpZDdDOnIkAT21t/kgFvhwmmorX2J96e8WO3qNQuoU8Vfk1WdIgh lbYHx1+BcnE1oO+oXtGPc8tg1KJ+x+ozWsWa2DBeqN54rTmgQtbOIuEa1+wKT2E8 zMPBS20JdNsKjdFCkKBLKFFA4qmY5cL0VudLQT0ua2kjfk2jvrFIyM+6qUdb4qx2 2/y18EyUm4pYP0hqJa/JlCWVkNwd5z52AUYLpRL09md7yEALIdTxxgPuOmgNcNQ= =i6k6 -----END PGP SIGNATURE----- --mJbDwDTw5rwvei6c3hWmGJjv5QplkFEiu--