From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WXvvD-0004ra-3P
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 13:04:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WXvv5-0005X6-1o
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 13:04:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23922)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WXvv4-0005X0-OC
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 13:04:14 -0400
Message-ID: <53457D82.8090109@redhat.com>
Date: Wed, 09 Apr 2014 11:04:02 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <cover.1397026795.git.hutao@cn.fujitsu.com>
	<2a4f67b31254a773cfae24ed750148c37e92e9cd.1397026795.git.hutao@cn.fujitsu.com>
In-Reply-To: <2a4f67b31254a773cfae24ed750148c37e92e9cd.1397026795.git.hutao@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="RtAjw3toNuwSlsjn4PnvkT645R6v1u801"
Subject: Re: [Qemu-devel] [PATCH v8 1/4] qapi: introduce PreallocMode and a
 new PreallocMode full.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--RtAjw3toNuwSlsjn4PnvkT645R6v1u801
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/09/2014 01:12 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>=20
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  block/qcow2.c    |  8 ++++----
>  qapi-schema.json | 14 ++++++++++++++
>  2 files changed, 18 insertions(+), 4 deletions(-)
>=20

> +++ b/qapi-schema.json
> @@ -4689,3 +4689,17 @@
>                'btn'     : 'InputBtnEvent',
>                'rel'     : 'InputMoveEvent',
>                'abs'     : 'InputMoveEvent' } }
> +
> +##
> +# @PreallocMode
> +#
> +# Preallocation mode of QEMU image file
> +#
> +# @off: no preallocation
> +# @metadata: preallocate only for metadata
> +# @full: preallocate all data, including metadata
> +#
> +# Since 2.0

You've missed 2.0.  This should be 2.1.  With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--RtAjw3toNuwSlsjn4PnvkT645R6v1u801
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTRX2CAAoJEKeha0olJ0NqFXQH/iGOLWIW9jb+UqGTTBxeUU2x
e0QmPT5B7yTfRVoJ9ioJy3JTW7Cj7a+jRlNB66kI/0Umrm3K2tPBDYBbFWmdW1U8
XUrNz9hwdTeYFPo1E4f8xzgI9/PFRJ7HnL9XRCAgTIR7F5Jr0AhkjWieJVmOOdFS
j5C+JW33V0CKhdHW6kveptIS/TuFyRpv4SfZVo0qmzlcFvvHTBIZOfhGAyN/KvVb
OnTBGk89arW1M3S0ScweFK8r13VnRbFBufvhaUC/XDMjCDZZMiJRaZsy5HiXseNT
3pCQdUdAJ/SPhk5vutJhfuRE4YbwFkIyofEhr0ZIDpGnweC77dA0ffVsqZXvsBA=
=S8eb
-----END PGP SIGNATURE-----

--RtAjw3toNuwSlsjn4PnvkT645R6v1u801--