From: Thomas Huth <thuth@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] smbus: Remove unneeded include
Date: Mon, 14 Jan 2019 11:39:12 +0100 [thread overview]
Message-ID: <53460d11-aab1-a811-ff49-f8051252bd64@redhat.com> (raw)
In-Reply-To: <20190112014156.6AA447456B3@zero.eik.bme.hu>
On 2019-01-12 02:32, BALATON Zoltan wrote:
> The file no longer uses error_report after review so the header is not
> needed either.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> Forgot to delete this when rewriting after review. This
> can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
>
> hw/i2c/smbus_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index bef24a1ca4..01b9439014 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -23,7 +23,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
> #include "qemu/units.h"
> #include "qapi/error.h"
> #include "hw/hw.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-01-14 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 1:32 [Qemu-devel] [PATCH] smbus: Remove unneeded include BALATON Zoltan
2019-01-14 10:39 ` Thomas Huth [this message]
2019-01-14 10:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53460d11-aab1-a811-ff49-f8051252bd64@redhat.com \
--to=thuth@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).