* [Qemu-devel] [PATCH] smbus: Remove unneeded include
@ 2019-01-12 1:32 BALATON Zoltan
2019-01-14 10:39 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-01-14 10:51 ` [Qemu-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: BALATON Zoltan @ 2019-01-12 1:32 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: David Gibson
The file no longer uses error_report after review so the header is not
needed either.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
Forgot to delete this when rewriting after review. This
can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
hw/i2c/smbus_eeprom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index bef24a1ca4..01b9439014 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -23,7 +23,6 @@
*/
#include "qemu/osdep.h"
-#include "qemu/error-report.h"
#include "qemu/units.h"
#include "qapi/error.h"
#include "hw/hw.h"
--
2.13.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] smbus: Remove unneeded include
2019-01-12 1:32 [Qemu-devel] [PATCH] smbus: Remove unneeded include BALATON Zoltan
@ 2019-01-14 10:39 ` Thomas Huth
2019-01-14 10:51 ` [Qemu-devel] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-14 10:39 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-ppc; +Cc: David Gibson, QEMU Trivial
On 2019-01-12 02:32, BALATON Zoltan wrote:
> The file no longer uses error_report after review so the header is not
> needed either.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> Forgot to delete this when rewriting after review. This
> can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
>
> hw/i2c/smbus_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index bef24a1ca4..01b9439014 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -23,7 +23,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
> #include "qemu/units.h"
> #include "qapi/error.h"
> #include "hw/hw.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] smbus: Remove unneeded include
2019-01-12 1:32 [Qemu-devel] [PATCH] smbus: Remove unneeded include BALATON Zoltan
2019-01-14 10:39 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2019-01-14 10:51 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-14 10:51 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-ppc; +Cc: David Gibson
On 1/12/19 2:32 AM, BALATON Zoltan wrote:
> The file no longer uses error_report after review so the header is not
> needed either.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Forgot to delete this when rewriting after review. This
> can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
>
> hw/i2c/smbus_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index bef24a1ca4..01b9439014 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -23,7 +23,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
> #include "qemu/units.h"
> #include "qapi/error.h"
> #include "hw/hw.h"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-12 1:32 [Qemu-devel] [PATCH] smbus: Remove unneeded include BALATON Zoltan
2019-01-14 10:39 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-01-14 10:51 ` [Qemu-devel] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).