From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGC3-0007iv-HP for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYGBv-000535-Sp for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGBv-00052n-Jz for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:42:59 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3AEgxMj023234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Apr 2014 10:42:59 -0400 Message-ID: <5346ADEF.8060907@redhat.com> Date: Thu, 10 Apr 2014 16:42:55 +0200 From: Max Reitz MIME-Version: 1.0 References: <1396961442-24046-1-git-send-email-mreitz@redhat.com> <1396961442-24046-6-git-send-email-mreitz@redhat.com> <53442B6B.1030902@redhat.com> In-Reply-To: <53442B6B.1030902@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 5/6] qemu-img: Specify backing file for commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 08.04.2014 19:01, Eric Blake wrote: > On 04/08/2014 06:50 AM, Max Reitz wrote: >> Introduce a new parameter for qemu-img commit which may be used to >> explicitly specify the backing file unto which an image should be > s/unto/into/ I was wondering about that and asked someone about it (German as well,=20 however), who said =E2=80=9Cunto=E2=80=9D would be correct. And since you= did not=20 complain in v1=E2=80=A6 ;-) I'll fix it. >> committed if the backing chain has more than a single layer. >> >> Signed-off-by: Max Reitz >> --- >> qemu-img-cmds.hx | 4 ++-- >> qemu-img.c | 22 +++++++++++++++------- >> qemu-img.texi | 8 +++++++- >> 3 files changed, 24 insertions(+), 10 deletions(-) > >> +If the backing chain of the given image file @var{filename} has more = than one >> +layer, the backing file unto which the changes shall be committed may= be > s/unto/into/ > s/shall/will/ As long as there are no bugs, right. *g* >> +specified as @var{backing_file} (which has to be part of @var{filenam= e}'s >> +backing chain). If @var{filename} is not specified, the immediate bac= king file >> +of the top image (which is @var{filename}) will be used. >> + > With those changes, > Reviewed-by: Eric Blake >