From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGdQ-0004NQ-9o for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYGdI-00060P-97 for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:11:24 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGdI-0005zb-4e for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:11:16 -0400 Received: by mail-pa0-f48.google.com with SMTP id hz1so4083187pad.7 for ; Thu, 10 Apr 2014 08:11:15 -0700 (PDT) Message-ID: <5346B48E.4010408@ozlabs.ru> Date: Fri, 11 Apr 2014 01:11:10 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1395638892-24481-1-git-send-email-aik@ozlabs.ru> <533E4050.3030705@ozlabs.ru> <533EA582.4090206@suse.de> In-Reply-To: <533EA582.4090206@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Bharata B Rao , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6Ry?= =?UTF-8?B?YmVy?= On 04/04/2014 11:28 PM, Alexander Graf wrote: > On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote: >> On 03/24/2014 04:28 PM, Alexey Kardashevskiy wrote: >>> Currently only migration fails if CPU version is different even a bit. >>> For example, migration from POWER7 v2.0 to POWER7 v2.1 fails because of >>> that. Since there is no difference between CPU versions which could >>> affect migration stream, we can safely enable it. >>> >>> This adds a helper to find the closest POWERPC family class (i.e. first >>> abstract class in hierarchy). >>> >>> This replaces VMSTATE_UINTTL_EQUAL statement with a custom handler which >>> checks if the source and destination CPUs belong to the same family and >>> fails if they are not. >>> >>> This adds a PVR reset to the default value as it will be overwritten >>> by VMSTATE_UINTTL_ARRAY(env.spr, PowerPCCPU, 1024). >>> >>> Since the actual migration format is not changed by this patch, >>> @version_id of vmstate_ppc_cpu does not have to be changed either. >>> >>> Signed-off-by: Bharata B Rao >>> Signed-off-by: Alexey Kardashevskiy >> >> Ping? > > Can't we just always allow migration to succeed? It's a problem of the tool > stack above if it allows migration to an incompatible host, no? After very convincing mail from Peter Maydell, this is the only solution, correct? If so, I'll make a patch then. -- Alexey