From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYQQ4-0005Gg-Kq for qemu-devel@nongnu.org; Thu, 10 Apr 2014 21:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYQPz-00077Y-2y for qemu-devel@nongnu.org; Thu, 10 Apr 2014 21:38:16 -0400 Message-ID: <53474780.5010605@redhat.com> Date: Thu, 10 Apr 2014 19:38:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1397151385-16730-1-git-send-email-mreitz@redhat.com> <20140411010907.GB19717@T430.nay.redhat.com> In-Reply-To: <20140411010907.GB19717@T430.nay.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FqqxdjQB5iA8lmMtRA3AMO37hf66uUshi" Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] block-commit: speed is an optional parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FqqxdjQB5iA8lmMtRA3AMO37hf66uUshi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/10/2014 07:09 PM, Fam Zheng wrote: > On Thu, 04/10 19:36, Max Reitz wrote: >> As speed is an optional parameter for the QMP block-commit command, it= >> should be set to 0 if not given (as it is undefined if has_speed is >> false), that is, the speed should not be limited. >> >> Signed-off-by: Max Reitz >> Reviewed-by: Eric Blake >> --- >> This patch was previously part of the "qemu-img: Implement commit like= >> QMP" series, but as this is a general bugfix, it has been separated. >> --- >=20 > Reviewed-by: Fam Zheng >=20 > The (generated) caller qmp_marshal_input_block_commit() actually leaves= speed > uninitialized, so we're not safe without this patch: > I'm wondering what the reason is to initialize pointers (like base and = device) > while leaving int64_t values uninitilized in the code generator? Because no one has applied this patch yet: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg04224.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FqqxdjQB5iA8lmMtRA3AMO37hf66uUshi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTR0eAAAoJEKeha0olJ0NqTPYH/3I4ONpMI+UssJVvBmzUzRJw W6wr4FelhQbX5NZMKeENL1Lyos7hUF403ML/PFz5qYK7isX3wlE9+gc0e/7lFcNV E0skTa5xT6EcaetJy2gVLYJh0Cs8339rh26AwGvyfsNgHzwLqggX+tl5sq/b4lSk vcuMOu36hO2mpEYfvA2MhNh9M+fFErncviwSkeHIsRC7QbvkWLIBrOt7qWhtczVI QFvITxk5n+7C0cUhaEauWrMkuNa5P9tHMrYecHrbfUcV7EKVRUSeGMnP7/Li9TS2 Bmj9KWZw60JFwrX3doPcs+AJ0y8cgBQquXe5Qp2gF1faGKYXtBRktO8RRW/FeNo= =4sdU -----END PGP SIGNATURE----- --FqqxdjQB5iA8lmMtRA3AMO37hf66uUshi--