From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYZp3-0004wK-0J for qemu-devel@nongnu.org; Fri, 11 Apr 2014 07:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYZot-0007tT-Sv for qemu-devel@nongnu.org; Fri, 11 Apr 2014 07:40:40 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:55522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYZot-0007tE-OE for qemu-devel@nongnu.org; Fri, 11 Apr 2014 07:40:31 -0400 Received: by mail-pa0-f54.google.com with SMTP id lf10so5334356pab.27 for ; Fri, 11 Apr 2014 04:40:30 -0700 (PDT) Message-ID: <5347D4A8.3040708@ozlabs.ru> Date: Fri, 11 Apr 2014 21:40:24 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <49b80c368134449bb2b9093204aef6b6@BL2PR03MB210.namprd03.prod.outlook.com> <53170DFB.5050005@ozlabs.ru> <53172815.50806@redhat.com> <20140305134011.GH1993@redhat.com> <531730D8.6010607@redhat.com> <20140305142134.GI1993@redhat.com> <531735C3.3010203@redhat.com> <20140410092437.GA7746@redhat.com> In-Reply-To: <20140410092437.GA7746@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Paolo Bonzini Cc: "Hong-Hua.Yin@freescale.com" , "qemu-devel@nongnu.org" , Li Zhang , "agraf@suse.de" , "qemu-ppc@nongnu.org" , "david@gibson.dropbear.id.au" On 04/10/2014 07:24 PM, Daniel P. Berrange wrote: > On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: >> Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: >>>> alpha/typhoon.c: b = pci_register_bus(dev, "pci", >>>> mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", >>>> pci-host/apb.c: phb->bus = pci_register_bus(DEVICE(phb), "pci", >>>> pci-host/bonito.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", >>>> sh4/sh_pci.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", >>>> pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci", >>>> >>>> plus pseries which has its own rules because it supports multiple PCI >>>> host bridges, but probably can also be changed from "pci" to NULL. >>> >>> I'm not sure I understand the effect of changing 'pci' to NULL in this >>> code, from libvirt's POV. Would using NULL mean we can rely on using >>> "pci.0" as the default PCI bus name or not ? >> >> Yes. But the next bus that the user creates (e.g. from a PCI bridge >> without an "id") would be "pci.1" instead of having a duplicate >> "pci.0"). Needs a bit more testing of course. > > What's the status of this ? I see the patch merged which only changes > the bus name for ppc64 spapr-pci board > > commit 1b8601b0ea0b91467561e0bbddd52a833e4b2b1a > Author: Alexey Kardashevskiy > Date: Thu Mar 6 14:11:00 2014 +1100 > > spapr-pci: Change the default PCI bus naming > > but AFAICT nothing got merged to change this for all the other boards as > discussed here :-( This is painful for libvirt since we have todo even > more hacks triggered off machine names now, instead of being able to > rely on pci.0 naming as we hoped. Sorry, I am missing the point. How could making a platform similar to many others force you to do more hacks, not less? -- Alexey