Re: [Qemu-devel] [PATCH v3 0/2] tests.acceptance: adds multi vm capability and basic migration test

[Wainer dos Santos Moschetta <wainersm@redhat.com>]

On 02/12/2019 05:38 PM, Caio Carrara wrote:
> This is the third attempt to add the multi vm capability to base class
> of acceptance tests.
>
> The difference from first version is that in this current version a
> simple migration test was added (done by Cleber) so the new code that is
> being added is properly used and we're not adding "new dead code".
>
> The difference from the second version is that in this current version
> the migration test being added was updated based on last reviews. It was
> added more status to consider the migration as finished and also
> assertions was added to check the migration success.

The new implementation of the migration test is very good IMHO.

>
> There are more tests and test cases that can be added, but I'm assuming
> this patch is complete enough and other series can be sent after
> covering the other cases.
>
> Caio Carrara (2):
>    tests.acceptance: adds multi vm capability for acceptance tests
>    tests.acceptance: adds simple migration test
>
>   docs/devel/testing.rst                    | 41 +++++++++++++++++-
>   tests/acceptance/avocado_qemu/__init__.py | 25 +++++++++--
>   tests/acceptance/migration.py             | 53 +++++++++++++++++++++++
>   3 files changed, 114 insertions(+), 5 deletions(-)
>   create mode 100644 tests/acceptance/migration.py
>

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>