From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Frederic Barrat <fbarrat@linux.ibm.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] target/ppc: Improve logging in Radix MMU
Date: Thu, 23 Dec 2021 08:17:56 -0800 [thread overview]
Message-ID: <53485311-22f7-72d3-b63f-9c890a385e88@linaro.org> (raw)
In-Reply-To: <20211222071002.1568894-1-clg@kaod.org>
On 12/21/21 11:10 PM, Cédric Le Goater wrote:
> +static bool __ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
Don't do the double-underscore thing.
It's technically a reserved namespace.
Use e.g. ppc_radix_xlate_impl.
Otherwise
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-23 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 7:10 [PATCH] target/ppc: Improve logging in Radix MMU Cédric Le Goater
2021-12-23 16:17 ` Richard Henderson [this message]
2022-01-04 7:42 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53485311-22f7-72d3-b63f-9c890a385e88@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=fbarrat@linux.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).