From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WYmw0-0001nS-Qq
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 21:40:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WYmvr-0003ld-PF
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 21:40:44 -0400
Received: from mail-yh0-x22d.google.com ([2607:f8b0:4002:c01::22d]:52701)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WYmvr-0003lY-KT
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 21:40:35 -0400
Received: by mail-yh0-f45.google.com with SMTP id a41so6122327yho.18
	for <qemu-devel@nongnu.org>; Fri, 11 Apr 2014 18:40:34 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53489983.6040703@redhat.com>
Date: Fri, 11 Apr 2014 21:40:19 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1396618620-27823-1-git-send-email-imammedo@redhat.com>	<1396618620-27823-24-git-send-email-imammedo@redhat.com>	<20140407113241.GA15315@redhat.com>	<20140407140037.6a61b5f2@nial.usersys.redhat.com>	<20140407120715.GB16369@redhat.com>	<20140407151211.10c62ac4@nial.usersys.redhat.com>	<20140407132530.GA16541@redhat.com>
	<20140407151906.GA17264@redhat.com>
In-Reply-To: <20140407151906.GA17264@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug
	callbacks generic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, aik@ozlabs.ru, hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, akong@redhat.com, quintela@redhat.com, armbru@redhat.com, aliguori@amazon.com, jan.kiszka@siemens.com, lersek@redhat.com, ehabkost@redhat.com, marcel.a@redhat.com, stefanha@redhat.com, chegu_vinod@hp.com, rth@twiddle.net, kwolf@redhat.com, s.priebe@profihost.ag, mreitz@redhat.com, vasilis.liaskovitis@profitbricks.com, afaerber@suse.de

Il 07/04/2014 11:19, Michael S. Tsirkin ha scritto:
> This means we can't cleanly implement an option for guest to
> disable ACPI and switch to native if supported,
> like the ACPI spec allows.
>
> If we change hotplug code to walk the tree top down
> and invoke all callbacks, then it will be fixed
> in a cleaner way: bridges would just do:
>
> 	if (dev->bus != self) {
> 		set_error
> 		return;
> 	}
>
> and suddently pci host can trap callbacks and redirect
> to acpi if it wants to.

I think this should be handled by making the q35 PCI host bridge 
implement HotplugHandler itself, possibly overriding the parent's 
implementation.

Paolo