From: Richard Henderson <richard.henderson@linaro.org>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Chinmay Rath <rathc@linux.ibm.com>
Subject: Re: [PATCH] target/ppc: Fix facility interrupt checks for VSX
Date: Thu, 20 Mar 2025 08:08:27 -0700 [thread overview]
Message-ID: <53508fc0-7bb4-4380-8043-a3b0344a7ba9@linaro.org> (raw)
In-Reply-To: <20250320115924.107996-1-npiggin@gmail.com>
On 3/20/25 04:59, Nicholas Piggin wrote:
> Facility interrupt checks in general should come after the ISA version
> check, because the facility interrupt and facility type themselves are
> ISA dependent and should not appear on CPUs where the instruction does
> not exist at all.
>
> This resolves a QEMU crash booting NetBSD/macppc due to
>
> qemu: fatal: Raised an exception without defined vector 94
>
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2741
> Cc: Chinmay Rath<rathc@linux.ibm.com>
> Debugged-by: Richard Henderson<richard.henderson@linaro.org>
> Fixes: aa0f34ec3fc7 ("target/ppc: implement vrlq")
> Fixes: 7419dc5b2b5b ("target/ppc: Move VSX vector storage access insns to decodetree.")
> Signed-off-by: Nicholas Piggin<npiggin@gmail.com>
> ---
> target/ppc/translate/vmx-impl.c.inc | 2 +-
> target/ppc/translate/vsx-impl.c.inc | 20 ++++++++++----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2025-03-20 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 11:59 [PATCH] target/ppc: Fix facility interrupt checks for VSX Nicholas Piggin
2025-03-20 15:08 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53508fc0-7bb4-4380-8043-a3b0344a7ba9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rathc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).