* [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback
@ 2023-11-13 8:13 Robert Hoo
2023-11-13 10:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Robert Hoo @ 2023-11-13 8:13 UTC (permalink / raw)
To: qemu-devel, mst, marcel.apfelbaum; +Cc: Robert Hoo
In the rollback in msix_set_vector_notifiers(), original patch forgot to
undo msix_vector_poll_notifier pointer.
Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll")
Signed-off-by: Robert Hoo <robert.hoo.linux@gmail.com>
---
hw/pci/msix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index ab8869d9d0..cd817f4ca8 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -648,6 +648,7 @@ undo:
}
dev->msix_vector_use_notifier = NULL;
dev->msix_vector_release_notifier = NULL;
+ dev->msix_vector_poll_notifier = NULL;
return ret;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback
2023-11-13 8:13 [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback Robert Hoo
@ 2023-11-13 10:05 ` Philippe Mathieu-Daudé
2023-11-13 13:03 ` Robert Hoo
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-11-13 10:05 UTC (permalink / raw)
To: Robert Hoo, qemu-devel, mst, marcel.apfelbaum
Hi Robert,
On 13/11/23 09:13, Robert Hoo wrote:
> In the rollback in msix_set_vector_notifiers(), original patch forgot to
> undo msix_vector_poll_notifier pointer.
Out of curiosity, nobody complained during 11 years, so in which
use case did you notice this?
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll")
> Signed-off-by: Robert Hoo <robert.hoo.linux@gmail.com>
> ---
> hw/pci/msix.c | 1 +
> 1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback
2023-11-13 10:05 ` Philippe Mathieu-Daudé
@ 2023-11-13 13:03 ` Robert Hoo
0 siblings, 0 replies; 3+ messages in thread
From: Robert Hoo @ 2023-11-13 13:03 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, mst, marcel.apfelbaum
On 11/13/2023 6:05 PM, Philippe Mathieu-Daudé wrote:
> Hi Robert,
>
> On 13/11/23 09:13, Robert Hoo wrote:
>> In the rollback in msix_set_vector_notifiers(), original patch forgot to
>> undo msix_vector_poll_notifier pointer.
>
> Out of curiosity, nobody complained during 11 years, so in which
> use case did you notice this?
>
Hi Philippe,
I stumbled upon this when looking into another issue.
I think, thanks to the caller's very standardized use, the omission has never
been exposed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-13 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 8:13 [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback Robert Hoo
2023-11-13 10:05 ` Philippe Mathieu-Daudé
2023-11-13 13:03 ` Robert Hoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).