From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqC9-0004gs-Am for qemu-devel@nongnu.org; Thu, 01 May 2014 08:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfqC7-0004rr-Ur for qemu-devel@nongnu.org; Thu, 01 May 2014 08:34:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqC7-0004rd-JW for qemu-devel@nongnu.org; Thu, 01 May 2014 08:34:31 -0400 Message-ID: <53623F50.2000802@redhat.com> Date: Thu, 01 May 2014 06:34:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140430190928.7884.69380.stgit@fimbulvetr.bsc.es> <20140430190934.7884.19499.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140430190934.7884.19499.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oif5uO6PijRw5k1rMKK4J7Uhpwv4PiT8d" Subject: Re: [Qemu-devel] [PATCH v10 1/4] qapi: [trivial] Break long command lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oif5uO6PijRw5k1rMKK4J7Uhpwv4PiT8d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 01:09 PM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > Reviewed-by: Eric Blake > --- > Makefile | 24 ++++++++++++++++++------ > tests/Makefile | 20 ++++++++++++++++---- > 2 files changed, 34 insertions(+), 10 deletions(-) >=20 > @@ -362,7 +368,13 @@ check-tests/test-qapi.py: tests/test-qapi.py > =20 > .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y)) > $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PA= TH)/%.json > - $(call quiet-command, PYTHONPATH=3D$(SRC_PATH)/scripts $(PYTHON) $(SR= C_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; ec= ho $$? >$*.test.exit, " TEST $*.out") > + $(call quiet-command, PYTHONPATH=3D$(SRC_PATH)/scripts \ > + $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \ > + <$^ \ > + >$*.test.out \ > + 2>$*.test.err; \ I've already made the comment several times that I would have put these three lines as one instead of excessively wrapping into three; I'm a bit surprised you haven't picked up on the hint when rebasing for other reasons. But the patch as-is is still valid, so my Reviewed-by is still okay whether or not you have a reason to spin a v11. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oif5uO6PijRw5k1rMKK4J7Uhpwv4PiT8d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYj9QAAoJEKeha0olJ0NqZwUH/j0aa9qdKaUZxo8+/UGhwOPL tRsbvBwcHu1DVOJE0pYTSlKBrw7fCEgcQ8fYf62KzacsGZqZKKaWL4+XJdcdbffJ oO/nRxcH6uNKSOxF8hLxOimNJIiLvzRslldx7mScsSbn8sW79ObvazaC5p33GGau ZPOA/ANuYyjmA9OiushIGwt/zZeBOaQdddK9fVjY0gwqhPs0fPjIl1glhoSzQHNm 2ticA8xR1NAKY/ERT4knM6m5Lo8G13SiRndlYlOzwLsTIKoTd31THED8HNW+Q5fd isn8pu1lNRLtshigYjjvjF2VJ2aIrv0ynt8EvFiEJa5kgTOiPqI+VpDb5qcQGxo= =O0z6 -----END PGP SIGNATURE----- --oif5uO6PijRw5k1rMKK4J7Uhpwv4PiT8d--