From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqFQ-0006NC-Jv for qemu-devel@nongnu.org; Thu, 01 May 2014 08:38:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfqFM-0006Ru-8s for qemu-devel@nongnu.org; Thu, 01 May 2014 08:37:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqFM-0006Rc-0q for qemu-devel@nongnu.org; Thu, 01 May 2014 08:37:52 -0400 Message-ID: <5362401A.1030105@redhat.com> Date: Thu, 01 May 2014 06:37:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140430190928.7884.69380.stgit@fimbulvetr.bsc.es> <20140430190946.7884.46553.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140430190946.7884.46553.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bKpx28W8TiX8JKx0acP7Mm7dQ4DAS7wJi" Subject: Re: [Qemu-devel] [PATCH v10 3/4] qapi: Use an explicit input file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bKpx28W8TiX8JKx0acP7Mm7dQ4DAS7wJi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 01:09 PM, Llu=C3=ADs Vilanova wrote: > Use an explicit input file on the command-line instead of reading from = standard > input. >=20 > It also outputs the proper file name when there's an error. >=20 > Signed-off-by: Llu=C3=ADs Vilanova > Reviewed-by: Eric Blake Technically, you made a non-trivial change (use of perl to sanitize SRC_PATH) in response to a comment that did not come from my review. You properly called it out in the cover letter, so I looked at this patch again; but in general, when making non-trivial changes, it's best to remove the Reviewed-by to make sure that earlier reviewers notice that they need to look again, and that they are still happy with the changes. Fortunately, in this case, your changes still look okay, so I'm okay with leaving my Reviewed-by on this version of the patch. > " TEST $*.out") > @diff -q $(SRC_PATH)/$*.out $*.test.out > - @diff -q $(SRC_PATH)/$*.err $*.test.err > + @# Sanitize error messages (make them independent of build directory)= > + @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)= /$*.err - > @diff -q $(SRC_PATH)/$*.exit $*.test.exit > =20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bKpx28W8TiX8JKx0acP7Mm7dQ4DAS7wJi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYkAaAAoJEKeha0olJ0NqBbsH/1VIBrwI7r4mVtrqVG2VZ9p1 e6PMq7F4GbMMq5glJ0UbiwbkfLhKp6zGTVFXuLpJwss/1JKhYrMvHieKttRmNkzp 40lpxP4hmI+2wcHNZT9Oqkja6+ONXwin3WX2ZGtpPhr7FVxIKsNQ6tQEpuvkhTTV RKJFn0K6jFT+J+T9yWI4NnOK+SAk9NI1l8/BNGZ/eZfNfmX1NBp3le6vz5xKEo7v RTGeGoPmMKy8TPcad+FnnKPsDJ1EcFBaMDL6hTCNxtM3ZirApTBtDB/V+R0k1Mb1 gLCg1/OR95sHcSxPsZtZUXRn+Ew5Qv03hGQL/sgTRGcnOSWtrNoPFTcPdJCoRnY= =CPzb -----END PGP SIGNATURE----- --bKpx28W8TiX8JKx0acP7Mm7dQ4DAS7wJi--