From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqOa-000080-KP for qemu-devel@nongnu.org; Thu, 01 May 2014 08:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfqOW-0001Mc-8I for qemu-devel@nongnu.org; Thu, 01 May 2014 08:47:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfqOV-0001MU-Vi for qemu-devel@nongnu.org; Thu, 01 May 2014 08:47:20 -0400 Message-ID: <5362424F.2040603@redhat.com> Date: Thu, 01 May 2014 06:47:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140430190928.7884.69380.stgit@fimbulvetr.bsc.es> <20140430190951.7884.90848.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140430190951.7884.90848.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ts4PItkPLlSI8WiJpHrJSEIN16imck89R" Subject: Re: [Qemu-devel] [PATCH v10 4/4] qapi: Add a primitive to include other files from a QAPI schema file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ts4PItkPLlSI8WiJpHrJSEIN16imck89R Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 01:09 PM, Llu=C3=ADs Vilanova wrote: > The primitive uses JSON syntax, and include paths are relative to the f= ile using the directive: >=20 > { 'include': 'path/to/file.json' } >=20 > Signed-off-by: Llu=C3=ADs Vilanova > --- > +++ b/tests/qapi-schema/include-after-err.json > @@ -0,0 +1,2 @@ > +{ 'include': 'include-simple-sub.json' } > +{ 'command' 'missing-colon' } In v9, Markus pointed out that 'include-after-err' is the wrong name for this test - you are testing that an error after include is detected correctly, and not the behavior of an error after an include. It's not a showstopper (I could live with v10 going into the tree), so: Reviewed-by: Eric Blake But if you want to spin a v11, then rename the related files and the Makefile rules to run the new name. As a rename is trivially testable by 'make check' still passing, then if that's the only change you make, I'm still okay if you keep my R-b in your v11 message. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ts4PItkPLlSI8WiJpHrJSEIN16imck89R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYkJPAAoJEKeha0olJ0Nq7osIAIOOWjpkC46pNYU4KtBufK0M mvUfw3KjSATcXeRUbS+eMAgKUQnVvrP4Qa424VQY/QAeBNhOtVW2dnq6q0f+/lVI Njux4tAnF9gS84M+r+ymfIfbYLumXWiPnPpMPqzDBZmMzJZiWQytqqsAqlAwP097 PX4iylkuogDGG/Bkfp3QC7G62a1U6t3ui53197yJECPRW0+vBa+o/CXqY4z1oBiV Q/Jf647KsOwad+Zig+CT1OHpL8JweQP0EINstAKXNuz7EQVXmYBioq+Ij2HLwZp4 o4eEOET+sGGpGI6kXIv3A+IzrT59gWQj/HE/SWaTUUVimtPxWL4OlpTz4aV42NU= =jz6n -----END PGP SIGNATURE----- --Ts4PItkPLlSI8WiJpHrJSEIN16imck89R--