From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfzAY-0000rq-GL for qemu-devel@nongnu.org; Thu, 01 May 2014 18:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfzAT-0003bD-Go for qemu-devel@nongnu.org; Thu, 01 May 2014 18:09:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfzAT-0003b9-7Y for qemu-devel@nongnu.org; Thu, 01 May 2014 18:09:25 -0400 Message-ID: <5362C611.9010300@redhat.com> Date: Thu, 01 May 2014 16:09:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1398918422-3019-1-git-send-email-wenchaoqemu@gmail.com> <1398918422-3019-7-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1398918422-3019-7-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hK449cmuNSrHALOwlU9S3kc5K1SLQRwQa" Subject: Re: [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hK449cmuNSrHALOwlU9S3kc5K1SLQRwQa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 10:26 PM, Wenchao Xia wrote: > Now monitor has been hooked on the new event mechanism, so the patches > later can convert event callers one by one. qmp_query_events() is also > switched to use new generated event defines. Note that old function > monitor_protocol_event() is kept for existing caller to avoid code brea= k, > but rate limiting is bypassed to avoid too many duplicated code. After > convertion, the function would be removed. s/convertion/conversion/ s/would/will/ >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 47 ++++++++++++++++++++++++++--------------------- > 1 files changed, 26 insertions(+), 21 deletions(-) >=20 > @@ -644,7 +648,8 @@ void monitor_protocol_event(MonitorEvent event, QOb= ject *data) > } > =20 > trace_monitor_protocol_event(event, event_name, qmp); > - monitor_protocol_event_queue(event, QOBJECT(qmp)); > + /* Bypass rate limiting for now */ > + monitor_protocol_event_emit(event, QOBJECT(qmp)); > QDECREF(qmp); I'm not quite sure I follow - is this comment evidence of something temporarily broken for the duration of conversions, that gets fixed later in the series; or are you breaking event rate limiting? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hK449cmuNSrHALOwlU9S3kc5K1SLQRwQa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYsYRAAoJEKeha0olJ0Nq6rcH+wcdXprUOe9xMN7cUg3uoNEy L1idRTgul2wM2pJ4Q9tBT3PFiyEIGGZDcIdKfF6fqAaUc8+AVLUeBStHvzT3Wcpo Jg4nYrELXWxxb/ufXKxds2ukxQ+acauXpxE86IgwexXK4i1XUhygB9bYPnEGUPHI pdrDpsjWeIoZWjO9l16vrpAYIi3OvqEVhb6Kx+SaU2PpEdog7Tpto+aoHBfJNG0w b1n4WeuYFiv/pvhamy6GJi74L3P6q6daFfsWWhddAptoExZmgXV/bvKqE0Hb+bBa v3Fs3jTnOB0Ikgv7KomyYrv4slSDoCjGutUL4y1FqmwwDDgPsnLP9VUycXu9Kb4= =XgvK -----END PGP SIGNATURE----- --hK449cmuNSrHALOwlU9S3kc5K1SLQRwQa--