From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCVb-00059L-Ad for qemu-devel@nongnu.org; Fri, 02 May 2014 08:24:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgCVW-0002kH-Dc for qemu-devel@nongnu.org; Fri, 02 May 2014 08:24:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCVW-0002k6-40 for qemu-devel@nongnu.org; Fri, 02 May 2014 08:24:02 -0400 Message-ID: <53638E5E.9010000@redhat.com> Date: Fri, 02 May 2014 06:23:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140430190928.7884.69380.stgit@fimbulvetr.bsc.es> <20140430190951.7884.90848.stgit@fimbulvetr.bsc.es> <5362424F.2040603@redhat.com> <87bnvgcr4o.fsf@fimbulvetr.bsc.es> In-Reply-To: <87bnvgcr4o.fsf@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fpOLntTRn1aS4fmBUF6G1GbcpuUMSCGu8" Subject: Re: [Qemu-devel] [PATCH v10 4/4] qapi: Add a primitive to include other files from a QAPI schema file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Luiz Capitulino , Markus Armbruster , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fpOLntTRn1aS4fmBUF6G1GbcpuUMSCGu8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:16 AM, Llu=C3=ADs Vilanova wrote: >>> +++ b/tests/qapi-schema/include-after-err.json >>> @@ -0,0 +1,2 @@ >>> +{ 'include': 'include-simple-sub.json' } >>> +{ 'command' 'missing-colon' } >=20 >> In v9, Markus pointed out that 'include-after-err' is the wrong name f= or >> this test - you are testing that an error after include is detected >> correctly, and not the behavior of an error after an include. >=20 >> It's not a showstopper (I could live with v10 going into the tree), so= : >=20 >> Reviewed-by: Eric Blake >=20 >> But if you want to spin a v11, then rename the related files and the >> Makefile rules to run the new name. As a rename is trivially testable= >> by 'make check' still passing, then if that's the only change you make= , >> I'm still okay if you keep my R-b in your v11 message. >=20 > Right, I forgot to comment on this change. I did not want to change the= name > because right now all tests start with "include-", which makes it simpl= e to spot > them on a directory list. Then name it include-before-err.json --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fpOLntTRn1aS4fmBUF6G1GbcpuUMSCGu8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTY45eAAoJEKeha0olJ0NqwjIIAI9TvJ0/MEmz3PBtpgaLWMqW aBwPYiQ01CgxIwGVQwlaTjryj7POg2r0IOMVc2HUlSLeDBasKrc0QdPI48UbQ5B4 clbVj5Nhk2XGwkC+TXfcMoQOQjjTwfRjWIIOBHpHpfeYCA7MxFsXPhP8WVBXFGwf fwHsBHoXCJYYbIUsI5obf5Y8J/Od8ZC7zaBoLxdZTtwD/ZkO8Y2jcgijK1MFhtcN c7e8+CYd71MNqs1ME0meOGxvsSkMgVy9faY7B4tnBNqVMJvYiAvd3fMRuA5B4rKf l1oxcbDTOh7gcvULR9AYHgYtoNqQ9CjMo7fu648FdHOi5AOFmN7tjAYoYHzK72I= =18xc -----END PGP SIGNATURE----- --fpOLntTRn1aS4fmBUF6G1GbcpuUMSCGu8--