From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgDJc-0006IY-5h for qemu-devel@nongnu.org; Fri, 02 May 2014 09:15:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgDJW-0006eH-1e for qemu-devel@nongnu.org; Fri, 02 May 2014 09:15:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgDJV-0006e3-Kx for qemu-devel@nongnu.org; Fri, 02 May 2014 09:15:41 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s42DFdxW013817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 2 May 2014 09:15:40 -0400 Message-ID: <53639A75.4040303@redhat.com> Date: Fri, 02 May 2014 15:15:33 +0200 From: Max Reitz MIME-Version: 1.0 References: <1398784072-3319-1-git-send-email-mreitz@redhat.com> <1398784640-3797-1-git-send-email-mreitz@redhat.com> <536069B9.2050409@redhat.com> In-Reply-To: <536069B9.2050409@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 12/14] iotests: Add test for backing-chain commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 30.04.2014 05:10, Eric Blake wrote: > On 04/29/2014 09:17 AM, Max Reitz wrote: >> Add a test for qemu-img commit on backing chains with more than two >> images. This test also checks whether the images above the base image >> are emptied and does therefore not work for qed and vmdk which requires >> it to be separate from 020. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/092 | 108 +++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/092.out | 59 +++++++++++++++++++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 168 insertions(+) >> create mode 100755 tests/qemu-iotests/092 >> create mode 100644 tests/qemu-iotests/092.out >> >> +# Two passes: >> +# 0: Two-layer backing chain, commit to upper backing file (default) >> +# (in this case, the top image will be emptied) >> +# 1: Two-layer backing chain, commit to lower backing file >> +# (in this case, the top image will stay as it is) > Should this test be modified to test the new -d option? Probably, yes, I'll include another pass. Max