From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgGYU-0000xZ-Ul for qemu-devel@nongnu.org; Fri, 02 May 2014 12:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgGYL-00064O-Tn for qemu-devel@nongnu.org; Fri, 02 May 2014 12:43:22 -0400 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:49925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgGYL-00064K-PK for qemu-devel@nongnu.org; Fri, 02 May 2014 12:43:13 -0400 Received: by mail-qg0-f41.google.com with SMTP id j107so5012284qga.28 for ; Fri, 02 May 2014 09:43:13 -0700 (PDT) Message-ID: <5363CB1D.6020806@gmail.com> Date: Fri, 02 May 2014 09:43:09 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1398959087-23590-1-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ulrich Weigand , Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On 05/02/2014 09:30 AM, Ulrich Weigand wrote: > Richard Henderson wrote on 01.05.2014 17:44:21: > >> Please review, and if you've got an ELFv2 system (nudge nudge), please >> give it a try and make sure it works. > > I ran into illegal instructions due to this patch: > >> tcg-ppc64: Support mulsh_i32 > [snip] >> case INDEX_op_muluh_i32: >> tcg_out32(s, MULHWU | TAB(args[0], args[1], args[2])); >> break; >> + case INDEX_op_mulsh_i32: >> + tcg_out32(s, MULHW | TAB(args[1], args[2], args[3])); >> + break; > > I guess that needs to be args[0], args[1], args[2] as well. > > With that change, I was able to start both qemu-system-x86_64 and > qemu-system-ppc64 and have them run through the respective BIOS/ > SLOF bootup sequence. Whoops. That what I get for rearranging the patches at the last minute. r~