From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgIVF-0004Oa-Ls for qemu-devel@nongnu.org; Fri, 02 May 2014 14:48:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgIVA-0006hr-RA for qemu-devel@nongnu.org; Fri, 02 May 2014 14:48:09 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:43996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgIVA-0006hl-MC for qemu-devel@nongnu.org; Fri, 02 May 2014 14:48:04 -0400 Received: by mail-qg0-f49.google.com with SMTP id j5so5087636qga.36 for ; Fri, 02 May 2014 11:48:04 -0700 (PDT) Sender: Richard Henderson Message-ID: <5363E860.6060307@twiddle.net> Date: Fri, 02 May 2014 11:48:00 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1399051958-9459-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1399051958-9459-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] bswap.h: Rename ldl_p, stl_p, etc to ldl_he_p, stl_he_p, etc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org On 05/02/2014 10:32 AM, Peter Maydell wrote: > We have an unfortunate naming clash between the functions > ldl_p, stl_p, etc defined in bswap.h (which have semantics > "load/store in host endianness") and the #defines of the same > name in cpu-all.h (which have the semantics "load/store in > target endianness"). > > Fortunately it turns out that the only users of the bswap.h > functions are all within bswap.h itself, so we can simply > rename them to include a _he_ infix for "host endianness". > > Signed-off-by: Peter Maydell > --- > Frankly I'm surprised that the only users of these functions > are the ones within bswap.h itself, but it's a lucky escape > from having to audit an enormous pile of code... > > We had talked about changing the "target-endian" accessors > to be ldl_te_p &c, but given the uses aren't tangled together > as I feared they would be, I'm not sure we can justify the > global function rename. I'm surprised too, but... good news, I guess. Reviewed-by: Richard Henderson r~