From: "Hervé Poussineau" <hpoussin@reactos.org>
To: "Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org, "Anthony Liguori" <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use level sensitive irqs
Date: Sat, 03 May 2014 22:39:37 +0200 [thread overview]
Message-ID: <53655409.4080903@reactos.org> (raw)
In-Reply-To: <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
Ping.
Le 22/04/2014 23:00, Hervé Poussineau a écrit :
> This is a guest-triggerable error, as seen when using Xenix 2.3.4.
> Replace hw_error by LOG_UNIMPL, so that guests have at least a chance to continue.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/intc/i8259.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index c6f248b..a069d04 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr addr64,
> s->init4 = val & 1;
> s->single_mode = val & 2;
> if (val & 0x08) {
> - hw_error("level sensitive irq not supported");
> + qemu_log_mask(LOG_UNIMP,
> + "i8259: level sensitive irq not supported\n");
> }
> } else if (val & 0x08) {
> if (val & 0x04) {
>
next parent reply other threads:[~2014-05-03 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
2014-05-03 20:39 ` Hervé Poussineau [this message]
2014-05-05 8:01 ` [Qemu-devel] [PATCH] i8259: don't abort when trying to use level sensitive irqs Michael S. Tsirkin
2014-05-05 20:02 ` Hervé Poussineau
2014-05-05 20:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53655409.4080903@reactos.org \
--to=hpoussin@reactos.org \
--cc=aliguori@amazon.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).