From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Wggjf-00038r-La
	for qemu-devel@nongnu.org; Sat, 03 May 2014 16:40:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1WggjW-0002Kl-GR
	for qemu-devel@nongnu.org; Sat, 03 May 2014 16:40:39 -0400
Received: from smtp1-g21.free.fr ([212.27.42.1]:33939)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1WggjW-0002KB-9q
	for qemu-devel@nongnu.org; Sat, 03 May 2014 16:40:30 -0400
Message-ID: <53655409.4080903@reactos.org>
Date: Sat, 03 May 2014 22:39:37 +0200
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use
 level sensitive irqs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

Ping.

Le 22/04/2014 23:00, Herv=C3=A9 Poussineau a =C3=A9crit :
> This is a guest-triggerable error, as seen when using Xenix 2.3.4.
> Replace hw_error by LOG_UNIMPL, so that guests have at least a chance t=
o continue.
>
> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>   hw/intc/i8259.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index c6f248b..a069d04 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr a=
ddr64,
>               s->init4 =3D val & 1;
>               s->single_mode =3D val & 2;
>               if (val & 0x08) {
> -                hw_error("level sensitive irq not supported");
> +                qemu_log_mask(LOG_UNIMP,
> +                              "i8259: level sensitive irq not supporte=
d\n");
>               }
>           } else if (val & 0x08) {
>               if (val & 0x04) {
>