From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgmM9-0006Ie-IJ for qemu-devel@nongnu.org; Sat, 03 May 2014 22:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgmM4-0007TD-Sr for qemu-devel@nongnu.org; Sat, 03 May 2014 22:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgmM4-0007T3-Jt for qemu-devel@nongnu.org; Sat, 03 May 2014 22:40:40 -0400 Message-ID: <5365A8A0.8000105@redhat.com> Date: Sat, 03 May 2014 20:40:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-2-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1sAk3TDg3o6ihDP2GTOo1AKfoPlahQfMn" Subject: Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to match current code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1sAk3TDg3o6ihDP2GTOo1AKfoPlahQfMn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 146 ++++++++++++++++++++++++++++++-----------= -------- > 1 file changed, 90 insertions(+), 56 deletions(-) Reviewed-by: Eric Blake I checked that this matches the current reality, and serves as a good metric for what the rest of the series cleans up. > =3D=3D=3D scripts/qapi-commands.py =3D=3D=3D > =20 > Used to generate the marshaling/dispatch functions for the commands de= fined > @@ -356,18 +395,8 @@ $(prefix)qmp-commands.h: Function prototypes for t= he QMP commands > Example: > =20 > mdroth@illuin:~/w/qemu2.git$ cat qapi-generated/example-qmp-marsha= l.c The file was missing the example command line that generated this file; I figured it out: mdroth@illuin:~/w/qemu2.git$ python scripts/qapi-commands.py \ --output-dir=3D"qapi-generated" --prefix=3D"example-" < example-schema.json if you want to add that to this patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1sAk3TDg3o6ihDP2GTOo1AKfoPlahQfMn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZaigAAoJEKeha0olJ0NqwZ4IAK6oFAigYS8tWYBk9zqAW0f2 5zlUxiuLz+8QQounKfxQ/Y5mVi9NFLHqFbzyDfyvSJq510y03Brl6CMGVfovuk7p XvWa8I2mnctsEhxJ2MHzn7HQoF5zavxF6/E7uoucBQJ3NSxKxaBRh25zObUJoJyE Nn4BGQ7StcKiDWlS1oNYueKrfU9oNM7HHCowiSU3IcfR46+6y+xooIgBHjjXiCAH euAqCQoW7WDlSex5Ey5zMMQVWjiz/hwvdbGi+8taxbHDTRM7E5JLH3grqhKFhqWW 1afNYG4ctgkg1rrMmEgy3KxikZoPPmawgOUE95deaUrbn029j7MvG4NnQTy9dcs= =as3U -----END PGP SIGNATURE----- --1sAk3TDg3o6ihDP2GTOo1AKfoPlahQfMn--