From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBNa0-0000M2-Tc for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBNZx-0006VM-MX for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:10:52 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:33698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cBNZx-0006VD-Eb for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:10:49 -0500 Received: by mail-wj0-f195.google.com with SMTP id kp2so14456924wjc.0 for ; Mon, 28 Nov 2016 07:10:49 -0800 (PST) Sender: Paolo Bonzini References: <20161128133201.16104-1-dgilbert@redhat.com> From: Paolo Bonzini Message-ID: <53664d7f-9492-f8b0-2997-7514d9021e03@redhat.com> Date: Mon, 28 Nov 2016 16:09:46 +0100 MIME-Version: 1.0 In-Reply-To: <20161128133201.16104-1-dgilbert@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, kraxel@redhat.com, quintela@redhat.com, amit.shah@redhat.com, pavel.dovgaluk@ispras.ru On 28/11/2016 14:31, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > 39c88f56 added VMState for pcspk but turned it on for > all machine types, this breaks backwards compatibility > to older machine types. > > If this is too late for 2.8 then I suggest we take the 1st > of these two patches, which just makes it a property to flip > for those of us who need it. Adding the 2nd patch after 2.8 > might cause problems for people using 2.8 with 2.7 machine > type. > > Dave > > Dr. David Alan Gilbert (2): > migration/pcspk: Add a property to state if pcspk is migrated > migration/pcspk: Turn migration of pcspk off for 2.7 and older > > hw/audio/pcspk.c | 10 ++++++++++ > include/hw/i386/pc.h | 5 +++++ > 2 files changed, 15 insertions(+) > Wow, I didn't know optional sections existed. We could have used it for hw/char/parallel.c, but that was added only a couple months before optional sections. Queued for 2.8. Paolo