From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhDqt-0005Vg-R1 for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhDqn-0003dc-MC for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhDqn-0003dS-EQ for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:13 -0400 Message-ID: <5367457E.40306@redhat.com> Date: Mon, 05 May 2014 10:02:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399276421-24949-1-git-send-email-famz@redhat.com> In-Reply-To: <1399276421-24949-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] docs/memory.txt: Fix document on MMIO operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Peter Maydell , Michael Tokarev , Jan Kiszka , "Michael S. Tsirkin" Il 05/05/2014 09:53, Fam Zheng ha scritto: > .impl.valid should be .impl.unaligned and the description needs some > fixes. > > .old_portio is removed since commit b40acf99b (ioport: Switch > dispatching to memory core layer). > > Signed-off-by: Fam Zheng > --- > docs/memory.txt | 10 +++++----- > include/exec/memory.h | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/docs/memory.txt b/docs/memory.txt > index 22eaec7..5bdbdb3 100644 > --- a/docs/memory.txt > +++ b/docs/memory.txt > @@ -232,8 +232,8 @@ various constraints can be supplied to control how these callbacks are called: > (in bytes) supported by the *implementation*; other access sizes will be > emulated using the ones available. For example a 4-byte write will be > emulated using four 1-byte writes, if .impl.max_access_size = 1. > - - .impl.valid specifies that the *implementation* only supports unaligned > - accesses; unaligned accesses will be emulated by two aligned accesses. > - - .old_portio and .old_mmio can be used to ease porting from code using > - cpu_register_io_memory() and register_ioport(). They should not be used > - in new code. > + - .impl.unaligned specifies that the *implementation* supports unaligned > + accesses; if false, unaligned accesses will be emulated by two aligned > + accesses. > + - .old_mmio can be used to ease porting from code using > + cpu_register_io_memory(). It should not be used in new code. > diff --git a/include/exec/memory.h b/include/exec/memory.h > index c084db2..1d55ad9 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -110,7 +110,7 @@ struct MemoryRegionOps { > /* If true, unaligned accesses are supported. Otherwise all accesses > * are converted to (possibly multiple) naturally aligned accesses. > */ > - bool unaligned; > + bool unaligned; > } impl; > > /* If .read and .write are not present, old_mmio may be used for > Applied, thanks! Paolo