From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhJTI-000631-Hs for qemu-devel@nongnu.org; Mon, 05 May 2014 10:02:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhJTA-0000J5-Gn for qemu-devel@nongnu.org; Mon, 05 May 2014 10:02:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhJTA-0000FP-A0 for qemu-devel@nongnu.org; Mon, 05 May 2014 10:02:12 -0400 Message-ID: <536799DD.2050200@redhat.com> Date: Mon, 05 May 2014 08:02:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399128428-25546-1-git-send-email-mreitz@redhat.com> <20140505122642.GG16173@stefanha-thinkpad.redhat.com> In-Reply-To: <20140505122642.GG16173@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qXG6gA3dS4sNSH4AWSgaK6MrBwBvmGnt8" Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qXG6gA3dS4sNSH4AWSgaK6MrBwBvmGnt8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/05/2014 06:26 AM, Stefan Hajnoczi wrote: >> - [ ! -x $seq ] && chmod u+x $seq # ensure we can run it >> + >> + if [ "$(head -n 1 $seq)" =3D=3D "#!/usr/bin/env python" ]; th= en >> + run_command=3D"$PYTHON $seq" >=20 > The code generally uses the older `` notation instead of $(). Please > use ``. I'd rather scrub the sources to get rid of all `` and use $() instead. `` is obsolete. Sounds like a good beginner's project, if someone wants a summer of code warmup... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qXG6gA3dS4sNSH4AWSgaK6MrBwBvmGnt8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ5neAAoJEKeha0olJ0NqsGQH+gInAfHhR1cekFTjNnh/t8XN AvR+CMrKZfk4fuAn+jhJWnYQrW8w90T9BY60L+NGxmUUDIH/q6f5C668loVfn+rA 2ZHA5Bj/Hp2s+SYnXC9p6jRHmN7EXeVYkhaHglLAdAIxOC9shchRXXJhXlaBoBn4 k9a39ELFgFNRvKxnsZr/3RLzRBc2Uc2kjVezmo2UjfhJ0Kbm7Sz6fSpti4N+JsZP 6S9IGlIiYb3ToRoWF3Uxlz8IJLj48THbCW067UhDtulbUYMH/CLPhW+Gu3tX6Zhi lxLZR2++VSLx5rCUOBNLXBIDjcmCgjRXKN7EXMfzJzZk2ZazVUCBUXItZA3reCQ= =VpsX -----END PGP SIGNATURE----- --qXG6gA3dS4sNSH4AWSgaK6MrBwBvmGnt8--