* [Qemu-devel] [PATCH] configure: remove bashism
@ 2014-05-02 11:41 Michael Tokarev
2014-05-04 1:39 ` Fam Zheng
2014-05-05 14:10 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-05-02 11:41 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev, Fam Zheng
Commit e26110cfc67d48 added a check for shacmd to create a hash
for modules. This check in configure is using bash construct &>
to redirect both stdout and stderr, whcih does fun things on some
shells. Get rid of it, use standard redirection instead.
Cc: Fam Zheng <famz@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 2fbec59..7442790 100755
--- a/configure
+++ b/configure
@@ -2627,7 +2627,7 @@ done
if test "$modules" = yes; then
shacmd_probe="sha1sum sha1 shasum"
for c in $shacmd_probe; do
- if which $c &>/dev/null; then
+ if which $c >/dev/null 2>&1; then
shacmd="$c"
break
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: remove bashism
2014-05-02 11:41 [Qemu-devel] [PATCH] configure: remove bashism Michael Tokarev
@ 2014-05-04 1:39 ` Fam Zheng
2014-05-05 14:10 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2014-05-04 1:39 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel
On Fri, 05/02 15:41, Michael Tokarev wrote:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules. This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some
s/whcih/which
> shells. Get rid of it, use standard redirection instead.
>
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
> if test "$modules" = yes; then
> shacmd_probe="sha1sum sha1 shasum"
> for c in $shacmd_probe; do
> - if which $c &>/dev/null; then
> + if which $c >/dev/null 2>&1; then
> shacmd="$c"
> break
> fi
> --
> 1.7.10.4
>
Thanks. With the typo in commit message fixed,
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: remove bashism
2014-05-02 11:41 [Qemu-devel] [PATCH] configure: remove bashism Michael Tokarev
2014-05-04 1:39 ` Fam Zheng
@ 2014-05-05 14:10 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2014-05-05 14:10 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial, Fam Zheng, qemu-stable
Il 02/05/2014 13:41, Michael Tokarev ha scritto:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules. This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some
> shells. Get rid of it, use standard redirection instead.
>
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
> if test "$modules" = yes; then
> shacmd_probe="sha1sum sha1 shasum"
> for c in $shacmd_probe; do
> - if which $c &>/dev/null; then
> + if which $c >/dev/null 2>&1; then
> shacmd="$c"
> break
> fi
>
Applied, and Cced qemu-stable too.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-05 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-02 11:41 [Qemu-devel] [PATCH] configure: remove bashism Michael Tokarev
2014-05-04 1:39 ` Fam Zheng
2014-05-05 14:10 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).