From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WhJbb-0002UR-1Q
	for qemu-devel@nongnu.org; Mon, 05 May 2014 10:11:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WhJbT-0003E5-SL
	for qemu-devel@nongnu.org; Mon, 05 May 2014 10:10:54 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53679BE1.9040401@redhat.com>
Date: Mon, 05 May 2014 16:10:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1399030869-23399-1-git-send-email-mjt@msgid.tls.msk.ru>
In-Reply-To: <1399030869-23399-1-git-send-email-mjt@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: remove bashism
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Fam Zheng <famz@redhat.com>, qemu-stable@nongnu.org

Il 02/05/2014 13:41, Michael Tokarev ha scritto:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules.  This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some
> shells.  Get rid of it, use standard redirection instead.
>
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c &>/dev/null; then
> +        if which $c >/dev/null 2>&1; then
>              shacmd="$c"
>              break
>          fi
>

Applied, and Cced qemu-stable too.