From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhKaF-0003h2-Em for qemu-devel@nongnu.org; Mon, 05 May 2014 11:13:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhKaA-0000DS-QM for qemu-devel@nongnu.org; Mon, 05 May 2014 11:13:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhKaA-0000DL-I2 for qemu-devel@nongnu.org; Mon, 05 May 2014 11:13:30 -0400 Message-ID: <53679E2E.2060702@redhat.com> Date: Mon, 05 May 2014 08:20:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-2-git-send-email-armbru@redhat.com> <5365A8A0.8000105@redhat.com> <87zjiwwwid.fsf@blackfin.pond.sub.org> In-Reply-To: <87zjiwwwid.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q2KeGNLbTtp2k9RMGWDmHPojU9BUC1Adb" Subject: Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to match current code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com, vilanova@ac.upc.edu This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q2KeGNLbTtp2k9RMGWDmHPojU9BUC1Adb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/05/2014 12:49 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >>> Example: >>> =20 >>> mdroth@illuin:~/w/qemu2.git$ cat qapi-generated/example-qmp-mars= hal.c >> >> The file was missing the example command line that generated this file= ; >> I figured it out: >> >> mdroth@illuin:~/w/qemu2.git$ python scripts/qapi-commands.py \ >> --output-dir=3D"qapi-generated" --prefix=3D"example-" < >> example-schema.json >> >> if you want to add that to this patch. >=20 > Sure, why not, but if there's nothing else to correct in this series, > I'd prefer a separate commit to a respin. Followup commit is just fine, if I don't turn up anything else while reviewing the rest of the series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --q2KeGNLbTtp2k9RMGWDmHPojU9BUC1Adb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ54uAAoJEKeha0olJ0NqZDcIAJwpAOycyD0NlFrsi0mnYI/J 2g0xgUp1rpkw2AYE3cryL8RnzDu/VvuMt9iEcs/ucl44tFBL9QyYQzBuSE+9mpad hT+jjgUutMGrR0mdxZOIGMyg1udocXJrf7iLPqMCFRKc3LtqBeAvUXi82OB5j8x2 PVcUJL9qoRdOoc07vqmVPiWdCcf5QFhqRxa1KP3RCb2/C9MJS/asDp4lEwZtBc2J Y0U2yECk46QjN6hpYfDFV2MmIAwsVICziNsME5liqT1RysBc0yDbZoXWPfILKfoH 6ZiFxYZOmgsY9PS9QpVTD7nnbdKlS6S5cEoJ3yVEJy1QBrnjEC4FzHeGW+CwYZM= =KqHw -----END PGP SIGNATURE----- --q2KeGNLbTtp2k9RMGWDmHPojU9BUC1Adb--