From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhJx5-0000Jc-Fk for qemu-devel@nongnu.org; Mon, 05 May 2014 10:33:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhJx0-0002mG-RH for qemu-devel@nongnu.org; Mon, 05 May 2014 10:33:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhJx0-0002m4-IX for qemu-devel@nongnu.org; Mon, 05 May 2014 10:33:02 -0400 Message-ID: <5367A115.8080901@redhat.com> Date: Mon, 05 May 2014 08:32:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-3-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lHwp1spndkv6OwQBSvbWUXhPE5fJqbvIu" Subject: Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lHwp1spndkv6OwQBSvbWUXhPE5fJqbvIu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Input and output marshalling functions do it differently. Change them > to work the same: initialize the I/O visitor, use it, clean it up, > initialize the dealloc visitor, use it, clean it up. >=20 > This delays dealloc visitor initialization in output marshalling > functions, and input visitor cleanup in input marshalling functions. > No functional change, but the latter will be convenient when I change > the error handling. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 8 ++++---- > scripts/qapi-commands.py | 27 ++++++++++++--------------- > 2 files changed, 16 insertions(+), 19 deletions(-) Tracking what the changes do in the examples certainly made it easier to review. Thanks. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lHwp1spndkv6OwQBSvbWUXhPE5fJqbvIu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ6EWAAoJEKeha0olJ0NqKLEH/1e1LMuPiVLy7n8u67Fr85Vh NCnHLzCj1rruJPE2tKv4wJ20eny09E+AWANAKmefevTtBgwXjeZDI5DPKxIEdJTZ HtWztSIv5iJ/7hi0CPXd1xkdgiNu1cRRpi1OQng0EqJw5wmdWtJykdO8aOKr+jD8 SgTD+pKaQOsKMIJLFfP+ilkIB4UpH4ZXXfuEg5P0xjtn9PJMxQCpJx38F/9+D+nN PrMy2372ZcX3xw1mdEUzfQA7t80jBhZM16mmsyW6omeeUUDoICiHx3ZKUCKW57eS i1Ux+WI0oC93euLOncbZdhYqwsbb9aZ3boLYV5fgFSxpQA8vTYi+TXsYpxwGsfE= =Z3WZ -----END PGP SIGNATURE----- --lHwp1spndkv6OwQBSvbWUXhPE5fJqbvIu--