From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLJd-0006gN-Ff for qemu-devel@nongnu.org; Mon, 05 May 2014 12:00:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhLJX-0000gV-Ew for qemu-devel@nongnu.org; Mon, 05 May 2014 12:00:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41972 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLJX-0000gN-9F for qemu-devel@nongnu.org; Mon, 05 May 2014 12:00:23 -0400 Message-ID: <5367B596.3000700@suse.de> Date: Mon, 05 May 2014 18:00:22 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1399301571-6769-1-git-send-email-somlo@cmu.edu> <20140505155138.GA16355@redhat.com> In-Reply-To: <20140505155138.GA16355@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , "Gabriel L. Somlo" , Alexander Graf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dslutz@verizon.com Am 05.05.2014 17:51, schrieb Michael S. Tsirkin: > On Mon, May 05, 2014 at 10:52:49AM -0400, Gabriel L. Somlo wrote: >> On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote: >>> From what I understand about the compat bits (which is little) this >>> makes a lot of sense. And the version is a proper property now, >>> which is great :). >>> >>> Acked-by: Alexander Graf >> >> Thanks! Here's a new version with only 8 bits dedicated to the >> "implementation version", as specified in the documentation for >> the "apic version register". >> >> Cheers, >> Gabriel >=20 >=20 > Acked-by: Michael S. Tsirkin >=20 > I'll pick this up unless there are objections. Objection! .compat_props are being added to the current pc and q35 machines rather than introducing pc-i440fx-2.1 and pc-q35-2.1 machines and adding the compat_props for the 2.0 versions only. If 2.1 machines without .compat_props get added and the alias is moved from 2.0 to 2.1, it'll be fine. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg