From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WhLi9-0008HQ-1b
	for qemu-devel@nongnu.org; Mon, 05 May 2014 12:25:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WhLi3-0001js-IZ
	for qemu-devel@nongnu.org; Mon, 05 May 2014 12:25:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WhLi2-0001fB-RD
	for qemu-devel@nongnu.org; Mon, 05 May 2014 12:25:43 -0400
Message-ID: <5367BB82.3050301@redhat.com>
Date: Mon, 05 May 2014 18:25:38 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1399128428-25546-1-git-send-email-mreitz@redhat.com>
	<20140505122642.GG16173@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140505122642.GG16173@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 05.05.2014 14:26, Stefan Hajnoczi wrote:
> On Sat, May 03, 2014 at 04:47:08PM +0200, Max Reitz wrote:
>> @@ -56,22 +57,22 @@ for IMGOPTS in "compat=0.10" "compat=1.1"; do
>>       echo === Create image with unknown header extension ===
>>       echo
>>       _make_test_img 64M
>> -    ./qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test header extension"
>> -    ./qcow2.py "$TEST_IMG" dump-header
>> +    $PYTHON qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test header extension"
>> +    $PYTHON qcow2.py "$TEST_IMG" dump-header
> Please use "$PYTHON" to humor the people who like to put spaces in their
> path names.

Following on Peter's explanation, me using ./configure --python=python2 
results in PYTHON='python2 -B', which probably won't work so well with 
quotes around it.

>> @@ -215,9 +222,16 @@ do
>>   
>>           start=`_wallclock`
>>           $timestamp && echo -n "        ["`date "+%T"`"]"
>> -        [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> +
>> +        if [ "$(head -n 1 $seq)" == "#!/usr/bin/env python" ]; then
>> +            run_command="$PYTHON $seq"
> The code generally uses the older `` notation instead of $().  Please
> use ``.

If I'd send a v2 with ``, Eric would probably want me to send a v3 with 
$(). ;-)

I personally don't really care what to use, but so far nobody has picked 
on me for using $(), whereas Eric once criticized my use of `` (which I 
had taken over from other tests).

Max