From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLrL-0001Ia-6X for qemu-devel@nongnu.org; Mon, 05 May 2014 12:35:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhLrG-00054A-9K for qemu-devel@nongnu.org; Mon, 05 May 2014 12:35:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLrG-000541-0d for qemu-devel@nongnu.org; Mon, 05 May 2014 12:35:14 -0400 Message-ID: <5367BDBB.4040509@redhat.com> Date: Mon, 05 May 2014 10:35:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399128428-25546-1-git-send-email-mreitz@redhat.com> <20140505122642.GG16173@stefanha-thinkpad.redhat.com> <5367BB82.3050301@redhat.com> In-Reply-To: <5367BB82.3050301@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sfVx6m73BfjhmCiQ9sEXnOpRT9JLh08G9" Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sfVx6m73BfjhmCiQ9sEXnOpRT9JLh08G9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/05/2014 10:25 AM, Max Reitz wrote: >> The code generally uses the older `` notation instead of $(). Please >> use ``. >=20 > If I'd send a v2 with ``, Eric would probably want me to send a v3 with= > $(). ;-) I won't make you resend if you are consistent with other code in the same file. But I also won't object to someone tackling a generic cleanup series to nuke ALL use of `` in the codebase. >=20 > I personally don't really care what to use, but so far nobody has picke= d > on me for using $(), whereas Eric once criticized my use of `` (which I= > had taken over from other tests). Consistency trumps aesthetics; I can point out obsolete usages, but won't reject a commit that is self-consistent in the use of that construc= t. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sfVx6m73BfjhmCiQ9sEXnOpRT9JLh08G9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ727AAoJEKeha0olJ0NqZUkIAJDoCmlNNNP47Ru9lF7D8pp+ UTQ7gJqgI/reyyV7DwR7z0Wzk88KtOzpRgifxjEsdkq2OU6gsAtEtkYjUwZfWq9M huavu3YFML304kno7YjXsLoqTJEXHcsIhimNJnPgBOHBCiBWoJQ6FTA6V9SxhkqH 6RP8azpjalI3dJeHBmhLlExXUNC9yukB755sH8df6RdZK16Ja5c5W3wWLqSHTj43 IDkkgh2unCKxMUr0zPt8oy9KE1F6TfwrjG9HeygmTywlplKhOY7mCOonZ/SOLTnD lwop0j2b0mXTSqmkpl+Rnd9WagQhJsMKag76kg9Cz6RKoemjqvuw01jh25QMB3g= =+Lh2 -----END PGP SIGNATURE----- --sfVx6m73BfjhmCiQ9sEXnOpRT9JLh08G9--