From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhMRl-00020Z-UZ for qemu-devel@nongnu.org; Mon, 05 May 2014 13:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhMRh-0002TA-7i for qemu-devel@nongnu.org; Mon, 05 May 2014 13:12:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhMRg-0002T5-Vx for qemu-devel@nongnu.org; Mon, 05 May 2014 13:12:53 -0400 Message-ID: <5367C690.8040606@redhat.com> Date: Mon, 05 May 2014 11:12:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-6-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vSB7Uj16DPpex69mAWeLm6BabF0K8U9ap" Subject: Re: [Qemu-devel] [PATCH 05/13] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vSB7Uj16DPpex69mAWeLm6BabF0K8U9ap Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Changing implicit indentation in the middle of generating a block > makes following the code being generated unnecessarily hard. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 32 ++++++++++++++------------------ > 1 file changed, 14 insertions(+), 18 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vSB7Uj16DPpex69mAWeLm6BabF0K8U9ap Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ8aQAAoJEKeha0olJ0Nq6AcH/2C69hJA/eQIGIEy3scdiKgo HEWAAT4qEahF4Y705z0FUJV+VUIhrGH1f+80mNriiOhG36AJfo5pZ5jwcdQ98VJa mRODaoAovMnunY3YjzUWKqz+heoX3LJ/h1PBen5Wulb75ZJMunVwzSEoT0UVjrBz 3IOIwreFJktTwgovgsv8fFMQfex4TllKv2HJBxje9lu/tzfKZSw0/HDKiUjqS3Wf NCsOhM6cagF0WC8UY057ZjLKq/zwhU7HMDBBvl3cHBrhnw3p+PK6VM3IzEKBS/4b Fum6vHFK88qFSlJhdW2wn1qHQ7wp/1+QfC+pWGBGmznPJK/jHAcgLlzYUSnVD1w= =WRZg -----END PGP SIGNATURE----- --vSB7Uj16DPpex69mAWeLm6BabF0K8U9ap--