From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1WhP7H-00064Z-E7
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:04:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1WhP78-00083U-UN
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:03:59 -0400
Received: from smtp5-g21.free.fr ([2a01:e0c:1:1599::14]:31792)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1WhP78-00083B-NS
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:03:50 -0400
Message-ID: <5367EE6F.6040602@reactos.org>
Date: Mon, 05 May 2014 22:02:55 +0200
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
	<53655409.4080903@reactos.org> <20140505080110.GA11352@redhat.com>
In-Reply-To: <20140505080110.GA11352@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use
 level sensitive irqs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

Le lun. 05 mai 2014 10:01:10 CEST, Michael S. Tsirkin a =C3=A9crit :
> On Sat, May 03, 2014 at 10:39:37PM +0200, Herv=C3=A9 Poussineau wrote:
>> Ping.
>>
>> Le 22/04/2014 23:00, Herv=C3=A9 Poussineau a =C3=A9crit :
>>> This is a guest-triggerable error, as seen when using Xenix 2.3.4.
>>> Replace hw_error by LOG_UNIMPL, so that guests have at least a chance=
 to continue.
>>>
>>> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
>
> Is it just "a chance" or does Xenix actually work well with this
> applied?

Yes,
With this patch, I can install and use Xenix 2.3.4a without any problem.
I can also start installation of Xenix 2.3.4q, but it fails due to not=20
finding an hard disk.

Regards,

Herv=C3=A9

>
>
>>> ---
>>>   hw/intc/i8259.c |    3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
>>> index c6f248b..a069d04 100644
>>> --- a/hw/intc/i8259.c
>>> +++ b/hw/intc/i8259.c
>>> @@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr=
 addr64,
>>>               s->init4 =3D val & 1;
>>>               s->single_mode =3D val & 2;
>>>               if (val & 0x08) {
>>> -                hw_error("level sensitive irq not supported");
>>> +                qemu_log_mask(LOG_UNIMP,
>>> +                              "i8259: level sensitive irq not suppor=
ted\n");
>>>               }
>>>           } else if (val & 0x08) {
>>>               if (val & 0x04) {
>>>
>