From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPi8-0004ka-Qz for qemu-devel@nongnu.org; Mon, 05 May 2014 16:42:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPi2-0004uw-LG for qemu-devel@nongnu.org; Mon, 05 May 2014 16:42:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48196 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPi2-0004u4-EO for qemu-devel@nongnu.org; Mon, 05 May 2014 16:41:58 -0400 Message-ID: <5367F794.4000209@suse.de> Date: Mon, 05 May 2014 22:41:56 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1399301571-6769-1-git-send-email-somlo@cmu.edu> <20140505155138.GA16355@redhat.com> <5367B596.3000700@suse.de> <20140505162150.GC5644@ERROL.INI.CMU.EDU> <5367CCB2.7050806@suse.de> <20140505180821.GD5644@ERROL.INI.CMU.EDU> In-Reply-To: <20140505180821.GD5644@ERROL.INI.CMU.EDU> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , Andreas F?rber Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dslutz@verizon.com, "Michael S. Tsirkin" On 05.05.14 20:08, Gabriel L. Somlo wrote: > On Mon, May 05, 2014 at 07:38:58PM +0200, Andreas F?rber wrote: >> Yes, with that patch it's okay, you just forgot to mention that >> dependency in your cover letter - also a change log from v1 is missing. >> Instead of quoting Alex in the cover letter, you should've placed his >> Acked-by before your Signed-off-by in the patches he ack'ed - unless you >> did major changes there (e.g., uint8_t), in which case it shouldn't be >> in the cover letter either. And please use [PATCH v5 n/m] as canonical >> ordering. :) > You're right; the dependency was mentioned in the v4 cover letter, but > in retrospect it makes perfect sense I should have kept appending to that > content instead of using it as a place to reply to the last person who > commented on the previous version :) > > Re. all that stuff you said about how to handle acked-by and > reviewed-by replies, is there a good spot where that process is > documented ? I noticed you all have a protocol in place for dealing > with that, but this is the first time I had a chance to screw it > up myself :) Googling around, I found this: > > https://www.kernel.org/doc/Documentation/SubmittingPatches > > Does QEMU have its own, or is this what I need for future reference ? We have some help on top at http://wiki.qemu.org/Contribute/SubmitAPatch but if you simply stick to what Linux does you're mostly fine in QEMU land as well :) Alex