From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPj9-0006OI-OP for qemu-devel@nongnu.org; Mon, 05 May 2014 16:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPj5-00057n-4R for qemu-devel@nongnu.org; Mon, 05 May 2014 16:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPj3-00057X-TU for qemu-devel@nongnu.org; Mon, 05 May 2014 16:43:03 -0400 Message-ID: <5367F7D0.2080803@redhat.com> Date: Mon, 05 May 2014 14:42:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-7-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="peqa2XrFHAaPhqV3HlV3C16kQKWDIMW7f" Subject: Re: [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --peqa2XrFHAaPhqV3HlV3C16kQKWDIMW7f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > By un-inlining the visit of nested complex types. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) >=20 > @@ -106,8 +122,6 @@ if (!error_is_set(errp)) { > =20 > if len(field_prefix): > ret +=3D mcgen(''' > -Error **errp =3D &err; /* from outer scope */ > -Error *err =3D NULL; Eww. Yeah, that's worth cleaning up. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --peqa2XrFHAaPhqV3HlV3C16kQKWDIMW7f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ/fQAAoJEKeha0olJ0NqwR0IAJ8IgY4zLp5ZxryQXavdm9g3 Yc6oHCLGejqLRakh1YzrIrGtWYkGo4zrUAK17fZuUPxYbQQxwLnE2401/DvhMKtl CwndGlJLTvkcYjOmHfPNYTM22/DS+Q7ErRiB9YaByv4Y149YTesQmKre9iCLS0ML QzoFZnrwWuDadSY7ODuVTbfboikUzHfCa84tzsaKSC6ksIqaCGZs0b158QZGpc6L gKagwBxjRsChkJ2nhIveCMwPdVSbjTruAAPmo9lwjed/bTW3M7XQOTPVNhjn++Ce gyP9XvDtoXOkCekMYYJw5f55pEv/3CEJGTh/Jvzn9mWG5PHsQ7HMvVV+LjueoR8= =VW9Q -----END PGP SIGNATURE----- --peqa2XrFHAaPhqV3HlV3C16kQKWDIMW7f--