From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPoG-0006En-FZ for qemu-devel@nongnu.org; Mon, 05 May 2014 16:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPo6-0006rU-Ir for qemu-devel@nongnu.org; Mon, 05 May 2014 16:48:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPo6-0006rC-BK for qemu-devel@nongnu.org; Mon, 05 May 2014 16:48:14 -0400 Message-ID: <5367F909.7070501@redhat.com> Date: Mon, 05 May 2014 14:48:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-9-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="stllBUN050LHTjpFJQeHrtLbQA8EBLxbJ" Subject: Re: [Qemu-devel] [PATCH 08/13] qapi: Un-inline visit of implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --stllBUN050LHTjpFJQeHrtLbQA8EBLxbJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > In preparation of error handling changes. Bonus: generates less > duplicated code. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 48 ++++++++++++++++++++++++++++++++++---------= ----- > 1 file changed, 34 insertions(+), 14 deletions(-) Too bad the example txt file didn't cover this case, to show the difference in the generated code. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --stllBUN050LHTjpFJQeHrtLbQA8EBLxbJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ/kJAAoJEKeha0olJ0Nq9DcIAKL8V7WtVNKzfFD41Z+Gpy9D 4gIc/bEFQvFo4NPQh3Dd7hFP5MShVkm5H2jVpOEYfQV8/kU/u0MbW89bjmg15ZZq y2g0tsM++XQa8r/5vkDRqgT2/H/l1QD/TwC4BYzPaON+1jT0erM0oB3RXtkczzgt nH8682RcWCse2ISOqxofY5FHczjDuEL2Z3MhiQOO4Wkwel7I9ifO6pRavzTXzFP6 +dqdgzjnmbipjJCdjtajC2XLt6339W+oQpplbpq7m2e9NO23wbPUTnydkyFyMy/d YDPL0BXjgnARVwGmKcOx23kISiA3cfMyA/nSDsQHQ2nn34Z1W3+X7oPgv8xcsCs= =37YP -----END PGP SIGNATURE----- --stllBUN050LHTjpFJQeHrtLbQA8EBLxbJ--