From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPqV-0001lw-TT for qemu-devel@nongnu.org; Mon, 05 May 2014 16:50:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPqQ-0007b4-VO for qemu-devel@nongnu.org; Mon, 05 May 2014 16:50:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPqQ-0007b0-Mr for qemu-devel@nongnu.org; Mon, 05 May 2014 16:50:38 -0400 Message-ID: <5367F990.6010102@redhat.com> Date: Mon, 05 May 2014 14:50:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-10-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-10-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xAknRMQcPI0FMd4mv19x2eDEdsj5hNsu2" Subject: Re: [Qemu-devel] [PATCH 09/13] hmp: Call visit_end_struct() after visit_start_struct() succeeds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xAknRMQcPI0FMd4mv19x2eDEdsj5hNsu2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > When visit_start_struct() succeeds, visit_end_struct() must be called. > hmp_object_add() doesn't when a member visit fails. As far as I can > tell, the opts visitor copes okay with the misuse. Fix it anyway. >=20 > Signed-off-by: Markus Armbruster > --- > hmp.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xAknRMQcPI0FMd4mv19x2eDEdsj5hNsu2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ/mQAAoJEKeha0olJ0NqfC8IAKpB05N7lt2i/A/Tn5iet+Gl iY1RDdWqyJ47RvgwftXXUBZIEGwufgS1ia6cTXrjoCrfcPCoOUDYMSSuEHTlYajN O+Lk95tBHd3iTU6Ph5s9a0VRCC81tS6CTtwMtQ4vDwsYTvjwKHUv4jkitJr3DMU7 CbBaxuhunIzmjPT666s1StF4NVyxBZaz/3NqjKSSVjGH3bkxT9421NZ+bVWUKmOh Y6hlws1inEFn5vVyItATKqP6/YZ/kugz5qDVZnUsfI9oU62VXMYpEqgIz03XLv5I P258Ugh0zy0S1g0za6E/Qe3K9F6rFU7ar9VP9K9DvQm+/M7UTdf+55qcErKkfYU= =r+Zr -----END PGP SIGNATURE----- --xAknRMQcPI0FMd4mv19x2eDEdsj5hNsu2--