From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPwL-00069v-Gc for qemu-devel@nongnu.org; Mon, 05 May 2014 16:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPwG-0001Dj-Jj for qemu-devel@nongnu.org; Mon, 05 May 2014 16:56:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPwG-0001Dc-Bl for qemu-devel@nongnu.org; Mon, 05 May 2014 16:56:40 -0400 Message-ID: <5367FB03.8040609@redhat.com> Date: Mon, 05 May 2014 14:56:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-11-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-11-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5Wf3sSiqd9CFgOWbsXtUD7x97S8QCfrG1" Subject: Re: [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after visit_start_struct() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5Wf3sSiqd9CFgOWbsXtUD7x97S8QCfrG1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > When visit_start_struct() succeeds, visit_end_struct() must not be s/succeeds/fails/ (this really confused me on my first read, until I saw the code and the subject line and determined the typo) > called. rtc_get_date() and balloon_stats_all() call it anyway. As > far as I can tell, they're only used with the string output visitor, > which doesn't care. Fix them anyway. >=20 > Signed-off-by: Markus Armbruster > --- > hw/timer/mc146818rtc.c | 23 +++++++++++++++-------- > hw/virtio/virtio-balloon.c | 25 +++++++++++++++++++------ > 2 files changed, 34 insertions(+), 14 deletions(-) With commit message fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5Wf3sSiqd9CFgOWbsXtUD7x97S8QCfrG1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ/sDAAoJEKeha0olJ0NqzjEH/iRDdsHD30EeUFnuZzStvqNO klQip7/VmuX94+xrqQhFqsiTrRlTG0YJDbOlCQUIGlLD4RNKjkr9/E07cgBjITz0 DfwD57n5cKeS60JDpUw/BPEerhcuMi3TRHq+bfdlw9WxmQXcX+WISqyig8jUhxfE QXtYOAJ7kpWRcMzvPKUfcaZyIhPd//3uFbSLwG5sjUZxsjI9m0sie5fE/exztmih +wnu3Aq0tAv9Hj8Jb870HsZKvBT5QeUpO+RPCkqAw9d5oEa5/gP5ijeOXONCtFZj 3G7GxmhKHzt7qgv3VybKFaXgyyEdM37sOn3CzMSXNDoXNZUdJHJe6BSD3w+F0cI= =VtQY -----END PGP SIGNATURE----- --5Wf3sSiqd9CFgOWbsXtUD7x97S8QCfrG1--